react-dropzone / attr-accept

JavaScript implementation of the "accept" attribute for HTML5 input element
MIT License
110 stars 24 forks source link

BREAKING CHANGE: drop core-js from dependencies which the app should be responsible for #31

Closed gfx closed 5 years ago

gfx commented 5 years ago

Any polyfills, not ponyfills which does not affect the global env, should be injected by the application, not by the library.

If you think this PR is okay, please add "sideEffects": false to package.json.


This is a breaking change (i.e. semver-major) because it may require the application code changes.

okonet commented 5 years ago

@rxmarbles what do you think? Also I'd like to move this package to react-dropzone org. Thoughts?

okonet commented 5 years ago

I moved the repo to the org after I mentioned it. Feel free to move the code along but in this case we might want to create a monorepo structure to accommodate other packages as well?

gfx commented 5 years ago

IMO I don't like monorepo because its version-to-version diffs are hard to understand.

gfx commented 5 years ago

ping

okonet commented 5 years ago

I’m not sure if that should be release as a major or minor version. Thoughts?

gfx commented 5 years ago

Neither am I, but if I were the product owner I'd bump the major version because some users are required to change their application code.

rxmarbles commented 5 years ago

I would agree with a major bump since it could be a breaking change for consuming apps

okonet commented 5 years ago

Okay in this case could you please rename the commit and include the breaking change message according to semantic versioning convention?

gfx commented 5 years ago

Marked it as BREAKING CHANGE both in the PR title and the commit messages. Is it okay?

okonet commented 5 years ago

I’ve adapted the commit message during the merge to comply semantic-versioning. Hopefully it’s going to be released as a major version. Thanks!

gfx commented 5 years ago

Thanks!

okonet commented 5 years ago

Not sure what's going on but travis CI can't trigger semantic release anymore. Can someone investigate? It says 403 but Im not sure what to do.

rxmarbles commented 5 years ago

@okonet I'll take a look when I have some free time. Hopefully today.

github-actions[bot] commented 4 years ago

:tada: This PR is included in version 2.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: