Closed rolandjitsu closed 4 years ago
Not sure. I didn’t do anything. Can we switch to GitHub automations?
Could you try generating a new github token and npm token and replace it in Travis? I can also generate a github token, but I cannot publish to npm as I think it's published under your personal username.
We could, but I don't have time at the moment to do it.
Could be related to https://github.com/semantic-release/semantic-release/issues/688. You could try refreshing the travis config for the repo on your machine, it might have some bad configs if the repo was moved from personal account to org.
I also don’t have time. What is required from me to remove it from my personal organization and move to this one?
I just created an org on npm react-dropzone. I think if we follow these steps we should be able to transfer the package(s).
Would also make sense to add me as contributor to this repo as well.
@okonet @rolandjitsu I can help, sorry I've been afk. Work project has been taking up a lot of my time. I can add you @rolandjitsu as maintainer once I'm at my laptop
@rolandjitsu can you add me to the npm org as well when you can
@rxmarbles thanks. Do you also have access to the npm packages? I need to be admin (both git w/ push permissions and npm) to be able to move those to the org. I just sent you an invite.
Also, what's your npm username?
@rolandjitsu I don't have access to them in npm unfortunately. Npm user is rxmarbles
@rxmarbles that's ok, @okonet can do it when he has time. I just need to be admin of this repo so that semantic-version can push the release commits.
I screwed the invitation and it has expired. Can someone invite me to npm org again? I'll transfer rights then.
@okonet sure thing. Is andrey@okonet.ru still your email?
Yep
Sent it 😄
@okonet meanwhile, could you give me push permissions to this repo so I can publish the latest version?
As for rights, you should have plenty of them:
@rolandjitsu I'm on npm now but not sure what to do now. I can invite maintainer to it but there is no option to move it to an org. Do you know how to do that?
Basically @okonet you just need to invite us to your packages in npm as maintainers and once you do that we can add it to the org, you can also add it to the org now that you are an member of the npm org
As for rights, you should have plenty of them:
Thanks. I tried to rebuild on Travis a couple of times but it keeps telling me I don't have enough permissions. I will investigate further these days to see if it's something else at fault.
@rolandjitsu I'm on npm now but not sure what to do now. I can invite maintainer to it but there is no option to move it to an org. Do you know how to do that?
As @rxmarbles suggested, you can do it as well as both you and @rxmarbles are admins and you can add new packages.
From the npm organization section, navigate to teams, then select packages under the developers team and there is the add existing package input where you can add this package and react-dropzone package as well.
This shouldn't require a change in npm token on Travis, it should still work. But it will also allow me and @rxmarbles to publish as well when needed.
@okonet are you still having issues accepting the invite to the org? if so @rolandjitsu can you make me an owner of the org? i would like to try something to re-send the invite. If that does not work I will have npmjs support handle adding @okonet to the org so we can get the packages moved. I would also like to see about setting up github actions to handle upgrades w/ their registry perhaps.
Npm org page looks like this for me so I don't know how to add a package there:
Actually what I also don't get is why do we need to manually release something? I'm going to update the token on this package and try re-building it.
Okay invited you both to the package. I didn't know you can have maintainer on npm ¯_(ツ)_/¯
@rxmarbles Is that enough from my side? Or do I need to do something with Travis setup? I can't wait to move away from 3 different platforms that needed to release a version
Can someone take some time and setup it over the GitHub Actions instead of Travis?
that's perfect @okonet i added the package to the npm org. When you have a chance can you add us both to the react-dropzone
package in npm as well so we can do the same?
Sure thing!
✅
@okonet nothing else should be needed on your side, I think at this point @rolandjitsu are you able to generate tokens and update them in travisci now? if you cannot i can tomorrow
I will update the tokens this weekend. But the issue I had was with the Git auth, standard-version keeps refusing to auth. I'm hoping I will have some time this weekend to look into it.
I still think the way to go would be to switch to GitHub Actions to reduce the complexity with auth etc.
It seems like https://github.com/react-dropzone/attr-accept/commit/5d4cdf8874ea9e88cd47da1f1d51430c6f10c708 was not published on npm due to some error on Travis:
Is it possible that we're missing some token or whatever token we used expired?
This change would probably also fix https://github.com/react-dropzone/react-dropzone/issues/887.