chore!: drop support for Internet Explorer

react-dropzone / file-selector

Convert a DragEvent or file input to a list of File objects

MIT License

95 stars 33 forks source link

chore!: drop support for Internet Explorer #109

Closed jonkoops closed 6 days ago

jonkoops commented 1 week ago

What kind of change does this PR introduce?

[ ] Bug Fix
[ ] Feature
[ ] Refactoring
[ ] Style
[ ] Build
[x] Chore
[ ] Documentation
[ ] CI

Did you add tests for your changes?

[ ] Yes, my code is well tested
[x] Not relevant

If relevant, did you update the documentation?

[ ] Yes, I've updated the documentation
[x] Not relevant

Summary Removes conditional code and tests for Internet Explorer and drops support for it.

Does this PR introduce a breaking change? Yes, it removes support for Internet Explorer entirely.

Other information Not relevant.

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 11756318444

Details

9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 11756009658:	0.0%
Covered Lines:	84
Relevant Lines:	84

💛 - Coveralls

jonkoops commented 1 week ago

@rolandjitsu this one is ready to go, can I ask you for a review?

rolandjitsu commented 1 week ago

There's apparently an IE mode in Edge that's supported until 2029 (see internet explorer 11 has retired)

And of course, we have committed to supporting IE mode in Microsoft Edge through at least 2029.

Not sure what that translates to. There may also be clients out there that are still using IE 🤔

I just thought that's worth mentioning it.

jonkoops commented 1 week ago

We're already shipping syntax that is no longer supported in Internet Explorer, so this realistically won't be an issue. Also the compatibility mode in Edge is intended to be used only on an allow-list basis for sites that experience compatibility issues, not as a blanket feature to enable on all sites, as that would most certainly cause most sites not to function.

jonkoops commented 1 week ago

@rolandjitsu any objection against merging this one? I have a couple of PRs that will build off this to resolve the remaining linting issues.

github-actions[bot] commented 6 days ago

:tada: This PR is included in version 3.0.0-beta.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: