search

react-everywhere / re-start

react-native template to target multiple platforms :globe_with_meridians: :iphone: :computer: with single codebase.
https://medium.com/@amoghbanta/write-once-use-everywhere-with-react-native-d6e575efe58e#.nfl50gwfg
MIT License
1.3k stars 85 forks source link

Added initial ESLint and Flow support #12

Closed amilajack closed 7 years ago

amoghbanta commented 7 years ago

Hi @amilajack, it is tough to review these many file changes. Could you please change the indentation back to as it was ( indent_size =4 from indent_size = 2) and then send the PR. Thanks.

amilajack commented 7 years ago

Fixed the indentation 🎉

ankitpopli1891 commented 7 years ago

Hey @amilajack, thanks for all the effort. It's much appreciated. I just have a small suggestion if you don't mind.

This pull request has grown a lot in size and it will be difficult for us to go through 13K LOC changes, most of which should be ignored (like indentation & other code style issues). It would be better if you could just send a different PR with only the flow-eslint-support related changes.

Sounds cool ?

amilajack commented 7 years ago

Most of the LOC changes are autogenerated type definitions and the yarn.lock. If you ignore those, reviewing should be much easier

kkszysiu commented 7 years ago

Wouldn't be better to use ident of 4 spaces everywhere? :)

Anyway, thanks!

piranna commented 7 years ago

Is the flow-typed folder needed? Can't it be autogenerated? This way the pull-request would be fairly smaller...

amoghbanta commented 7 years ago

Closing this one as this PR would no longer be valid with the template.