Closed christopherhein closed 7 years ago
Hi @christopherhein, I came across react-navigation couple of days back, haven't tried it yet but it is in the near plan to test it for web and native using an all common code base. I completely agree that it "could replace the need for the multiple handling of navigation" and reduce the duplication. Seems theoretically perfect to me but i could comment on it better once I give it a try.
For now it doesn't work so good.
They web implementation is very limited for now. I'm trying to do something about it but so far no success.
That's the differences: https://github.com/react-community/react-navigation/blob/master/src/react-navigation.js https://github.com/react-community/react-navigation/blob/master/src/react-navigation.web.js
Without StackNavigator/TabNavigator it seems to be very limited and it gives only routing abilities, no views. I would love to have it.
Ah sweet, thanks for the info!
After some tweaks I'm able to run StackNavigator :) It should work the same on both Android, iOS and web.
The example from web:
But TabNavigator is really what I desire here.
I will try to push some example how to implement it when I make some code cleanup 👍
Oh should I reopen @kkszysiu ?
@kkszysiu , how did you get the css to work? Changing the react-navigation.web.js file allowed me to use StackNavigator but the css is all broken
@kkszysiu did you do this in a fork somewhere? wanted to check out what was required to get it working
I guess this should be reopened as react-navigation is the way to go
@amoghbanta Any update on this?
hey @fotiDim, so I've working on a complete rewrite of react-native-everywhere. The update on this is that react-router guys released v4 and that is exactly what fits our requirement. My aim is to keep it more of plug and play where in you can just replace react-router with react-navigation if you prefer that. It'll be out in a couple of days.
@amoghbanta any insights to share on where react navigation fell short?
@amoghbanta - great work and thanks!!! Any news on the rewrite?
hey @ajostergaard, this branch is where the rewrite is going on. Now, since react-native supports templates, so this project will be more of a template(supporting multiple platforms) with some additional scripts. No more git cloning. We are also working on a component library which would support multiple platforms too.
hey @fotiDim, its just that react-router's API was an exact match/requirement for us. I personally haven't played much with react-navigation so I can't comment. As i said earlier, it would be more of a plug and play thing, so you can use the one you feel is right for your project.
Thanks @amoghbanta. How mature is the template? Ready for a relative beginner to use for an app?
Template is ready to be used, you guys can give it a try and as of now it works on react-router v4. Closing this one.
Seems like the new https://github.com/react-community/react-navigation project could replace the need for the multiple handling of navigation in https://github.com/amoghbanta/reactNativeEverywhere/tree/master/src web integration is documented here - https://reactnavigation.org/docs/guides/web
Still new but curious if this would help reduce duplication. As well redux integration seems to flow a bit better than with react-native-flux-router
Thoughts?