search

react-everywhere / re-start

react-native template to target multiple platforms :globe_with_meridians: :iphone: :computer: with single codebase.
https://medium.com/@amoghbanta/write-once-use-everywhere-with-react-native-d6e575efe58e#.nfl50gwfg
MIT License
1.3k stars 85 forks source link

Unmeet peerdependencies #24

Open piranna opened 7 years ago

piranna commented 7 years ago 
npm WARN react-router-native@4.0.0 requires a peer of react@^15 but none was installed.
npm WARN react-router-dom@4.0.0 requires a peer of react@^15 but none was installed.
npm WARN react-native-web@0.0.88 requires a peer of react@15.4.x || 15.5.x but none was installed.
npm WARN react-dom@15.5.4 requires a peer of react@^15.5.4 but none was installed.
npm WARN react-router@4.0.0 requires a peer of react@^15 but none was installed.
npm WARN react-native-windows@0.42.0 requires a peer of react-native@~0.42.0 but none was installed.
npm WARN react-native-windows@0.42.0 requires a peer of react@~15.4.1 but none was installed.

How can this be fixed? It's the first time that I works with ReactNative...

piranna commented 7 years ago

There are dependencies conflict, react-dom requires react@15.5.4 but other dependencies requires react@15.4.2...

JackWells commented 7 years ago

So following the instructions, we get the errors as reported here. Then we run the script "node scripts/addDevDependencies.js" (after cd-ing into the project folder, first, or it won't work) which is supposed to fix this, but we get some of the same errors, again.

How do we install the various needed versions or 'react' which will meet the dependencies of react-dom, react-native, react-router, and react-test-renderer?

Maybe a specific version of Node needs to be installed (the directions in the linked page for that step do not specify which version)?

piranna commented 7 years ago

Seems it's a bit of mix-and-match, I have been updating web dependencies but seems it broke Android support. We'll need to add tests to be sure it works on all supported platforms, pull-requests are welcome.

JackWells commented 6 years ago

Ok - I'm new to this (never used react-native framework before), so this is probably not the way it "should be done" - but this is how I got "npm run web" to work on my system: https://www.pastiebin.com/embed/59facbd91864a I haven't tried android and other builds, yet. I'll update if I find a better combination of versions and/or when I learn how these changes could be correctly formed into a pull-request of the project.

piranna commented 6 years ago

I think is more a problem of versions conflicts making several versions of the same package to be installed. Does anyone knows how to detect this situation and what packages are causing it? Having installed a single version of each dependency without warnings should fix that.