react-financial / react-financial-charts

Charts dedicated to finance.
https://react-financial.github.io/react-financial-charts/
MIT License
1.21k stars 211 forks source link

Resizeable indicator subcharts #379

Open abforce opened 4 years ago

abforce commented 4 years ago

I'm submitting a...

What is the current behavior

Subcharts have fixed heights and can't be resized by user.

What is the expected behavior

Users being able to resize subcharts by dragging the edges.

markmcdowell commented 4 years ago

Hi there, thanks for the feature request. Do you mean when you create another chart below a main one? Are you specifying the heights of this yourself?

abforce commented 4 years ago

Thanks for your prompt response.

Do you mean when you create another chart below a main one?

Yes.

Are you specifying the heights of this yourself?

Currently heights can be set by the developer and users cannot change them. A resize handle with an appropriate cursor would be nice to let users change those heights.

markmcdowell commented 4 years ago

Got it, we're currently going through a rewrite. I'll keep this issue as a request but definitely something we'll add.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

amirmamaghani commented 1 year ago

any updates on this? I'm using split-pane-react component which handles this.