react-hook-form / documentation

📋 Official documentation
http://react-hook-form.com
MIT License
727 stars 1.04k forks source link

The linked URLs are incorrect #1004

Closed roottool closed 1 year ago

roottool commented 1 year ago

Overview

On the "Advanced Usage" page, two linked URLs are wrong.

"FormContext" in Connect Form

Expected behavior

Linked URL is /docs#useFormContext such as a current link of FormProvider. https://github.com/react-hook-form/documentation/blob/e7cdd0fb68f61667beaca25a4aab5fea88a59178/src/content/advanced-usage.mdx#L306

Actual behavior

The current URL(/docs/useFormContext) is incorrect. https://github.com/react-hook-form/documentation/blob/e7cdd0fb68f61667beaca25a4aab5fea88a59178/src/content/advanced-usage.mdx#L272

We receive a 404 response from this URL. 404 Not Found

"FormProvider" in FormProvider Performance

Expected behavior

Move to FormProvider in API doc.

Actual behavior

Move to useFormContext in API doc. https://github.com/react-hook-form/documentation/blob/e7cdd0fb68f61667beaca25a4aab5fea88a59178/src/content/advanced-usage.mdx#L306

bluebill1049 commented 1 year ago

Would you like to send a PR on this?

roottool commented 1 year ago

Yes. I will try it this weekend.

roottool commented 1 year ago

Thank you for reviewing! This issue fixed by #1005. Could you close this issue?

bluebill1049 commented 1 year ago

Thank you 🙏