search

react-hook-form / resolvers

📋 Validation resolvers: Yup, Zod, Superstruct, Joi, Vest, Class Validator, io-ts, Nope, computed-types, typanion, Ajv, TypeBox, ArkType, Valibot, effect-ts and VineJS
https://react-hook-form.com/
MIT License
1.74k stars 159 forks source link

feat: effect-ts resolver #676

Closed binaryartifex closed 4 months ago

binaryartifex commented 5 months ago

Initial submission of an effect-ts compatible react-hook-form resolver that accepts schemas from the @effect/schema library.

binaryartifex commented 5 months ago

@bluebill1049 cheers for the approvals mate. but im at a loss now as to how to fix this last failing check...generate a whole new pnpm-lock file maybe? im cautious of doing that as its bitten me in the ass in the past, especially with older or legacy transient packages in the mix...

binaryartifex commented 5 months ago

so it looks like the lockfile pnpm version got bumped from 6 to 9. the github workflows in the lib that leverage pnpm/action-setup@v2 are all set to use version 7. According to a few discussions, namely here and here, this might be the issue...

bluebill1049 commented 5 months ago

@bluebill1049 cheers for the approvals mate. but im at a loss now as to how to fix this last failing check...generate a whole new pnpm-lock file maybe? im cautious of doing that as its bitten me in the ass in the past, especially with older or legacy transient packages in the mix...

@jorisre do you have any idea on this issue? 🙏

binaryartifex commented 5 months ago

@bluebill1049 looks like that last commit bumping the pnpm versions in the github ci scripts fixed it :thumbsup:

bluebill1049 commented 5 months ago

nice, let's go~

binaryartifex commented 5 months ago

@bluebill1049 all good to go mate. are there scheduled releases or anything further needed from me with this pull request? when can we expect this to be merged?

bluebill1049 commented 5 months ago

Let's release this Saturday, if something wrong I can still action it.

bluebill1049 commented 4 months ago

looks like need to upgrade node to 20: image

github-actions[bot] commented 4 months ago

:tada: This PR is included in version 3.4.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: