search

react-icons / react-icons

svg react icons of popular icon packs
https://react-icons.github.io/react-icons/
Other
11.6k stars 754 forks source link

release `@react-icons/all-files` #593

Open maddhruv opened 2 years ago

maddhruv commented 2 years ago

Describe the bug Looks like @react-icons/all-files hasn't been released lately with react-icons so I am missing the newly added icons packs

Minimal sample repository Not Required

Expected behavior For example Tabler Icons are missing from all-files, Can you please do a release with latest react-icons

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

maddhruv commented 2 years ago

@kamijin-fanta

SukkaW commented 2 years ago

@maddhruv I believe it is caused by too many files generated, causing npm to refuse to host the package.

Here is what happened when I was trying to publish the package under my own npm scope:

image
maddhruv commented 2 years ago

I think by npm pack and npm publish --tarball` using the tarball you would be able to publish, can you please try

maddhruv commented 2 years ago

Hey @nolanleung looks like with the latest release as well, the all-files package is not updated. Can you look into this?

kamijin-fanta commented 2 years ago

I tried to publish, but it was rejected due to too many files. I think I need to plan on splitting the package.

SukkaW commented 2 years ago

I tried to publish, but it was rejected due to too many files. I think I need to plan on splitting the package.

One possible solution is to split the ESM and CJS packages, which could reduce the number of files to half.

kamijin-fanta commented 2 years ago

I don't think that is a good solution. Currently the package contains 80,000 files, which is causing problems such as long installation times. Also, the number of icons will continue to increase.

codsane commented 1 year ago

I don't think that is a good solution. Currently the package contains 80,000 files, which is causing problems such as long installation times. Also, the number of icons will continue to increase.

While it may defeat the purpose of having a package named "all-files", maybe the icons could be split up into packages based on their icon library? So, a @react-icons/fa package, a @react-icons/hi package, and so-on?

fregante commented 1 year ago

Those packages already exist but they don't contain the separate icons. The main setup should just be fixed to export single files in each package and then you should deprecate this duplicate "all-icons" package.

Wolverin-e commented 1 year ago

To all the people still finding a workaround, we can also do: npm install link_to_gzipped_tarball.

For an Example:

$ npm i https://github.com/react-icons/react-icons/releases/download/v4.7.1/react-icons-all-files-4.7.1.tgz

This also adds a dependency in the package.json file.

References:

stephenasuncionDEV commented 10 months ago

When is this being updated?