Fix: Strict ESM loader compatibility

e1himself commented 6 months ago

Hi!

The ESM exports the package provided are not conforming with the ESM loader spec:

All import paths should point to the exact file with the extension included
To be compatible with Node.js ESM implementation, the files have to have .mjs extension

These changes, in particular, fix the package compatibility with Deno, which only works with ECMAScript modules.

Fixes: #717, alternative to #785

What has been changed:

/esm/ and /cjs/ folders merged together -- there's no need to separate them and to duplicate .d.ts declarations
TS is now producing .d.ts files only, while the JS artifacts are built with Babel with two different configurations: ESM and CommonJS
fixed ESM loader compatibility by converting folder and extension-less file imports to full file paths with extensions
added subpath exports configuration to the react-icons package.json file

Let me know if there's anything else I have to do to get this code merged.

Thank you!

kamijin-fanta commented 5 months ago

Excellent work! Doesn't look like you are breaking compatibility, but just in case I am considering releasing a major version up.

kamijin-fanta commented 5 months ago

publish in react-icons@5.0.0 :tada:

e1himself commented 5 months ago

Thank you! :+1:

react-icons / react-icons