search

react-keycloak / react-native-keycloak

React Native components for Keycloak
MIT License
171 stars 48 forks source link

Deploy to Google Play #105

Closed glauberbrack closed 2 years ago

glauberbrack commented 2 years ago

Describe the bug I detected a bug when deploying to Google Play and already made a fix, but I can't open any PR.

IronTony commented 2 years ago

What's the matter opening a PR?

glauberbrack commented 2 years ago

$ git push --set-upstream origin fix/query-all-packages

remote: Permission to react-keycloak/react-native-keycloak.git denied to glauberbrack. fatal: unable to access 'https://github.com/react-keycloak/react-native-keycloak/': The requested URL returned error: 403

It's appear that I don't have permission to create a new branch to create a new PR

IronTony commented 2 years ago

You can't push directly to our repo. You have to:

  1. fork this repo (branch: main)
  2. do the fix onto your git forked repo
  3. from your fixed forked repo, do the PR onto our repo
  4. then we will check and merge if everything is fine

Thank you for the future PR 🥇

glauberbrack commented 2 years ago

Awesome! It's my first open source contributing. Thank you by the explanation!

IronTony commented 2 years ago

https://github.com/react-keycloak/react-native-keycloak/pull/106