react-keycloak / react-native-keycloak

React Native components for Keycloak
MIT License
171 stars 48 forks source link

chore: react-native-inappbrowser-reborn update #106

Closed glauberbrack closed 2 years ago

glauberbrack commented 2 years ago

Description

In this package we have react-native-inappbrowser-reborn as one of dependencies. The current version has a android permission inside the AndroidManifest.xml:

More about the permission: Link here

This is a specific permission and Google has been blocking all new deploys that use this permission. The inappbrowser is already update, so we need to update our package as well

Fixes # (issue) Update react-native-inappbrowser-reborn to the current and stable version 3.7.0

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

In this branch, run yarnor npm i Publish lib in local, using yalc publish On one project that use the package, install using yalc add @react-keycloak/native@0.6.3 Run on Android and iOS After test, remove the package from yalc: yalc remove @react-keycloak/native@0.6.3

Test Configuration:

  • Device: iPhone 13 (iOS 15.5)

Kapture 2022-09-15 at 10 26 53

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules
maicon-passos commented 2 years ago

Up!

jmachadogui commented 2 years ago

Extremely necessary!