search

react-mdc / react-material-components-web

React wrapper of Google's Material Components Web
https://react-mdc.github.io/
178 stars 15 forks source link

[common] TypeScript #22

Closed Hardtack closed 7 years ago

Hardtack commented 7 years ago

I'm using react-material-components-web for my private project. And that project seems gonna use TypeScript instead of ECMA6 + Flow. So I'm considering to support TypeScript for react-material-components-web

Supporting TypeScript will be cool feature.

We have two options to do this

  1. Migrate to TypeScript and write .flow file manually or use flowgen

    • Pros

    • We can you TypeScript's mature tools

    • ~Can be easily used by my private project~

    • Cons

    • Should migrate all codes

    • Have to learn new language

  2. Just write .d.ts files

    • Pros

    • Don't have to migrate our codes

    • Cons

    • Should keep fight with immatureness of flow

Hardtack commented 7 years ago

Ref. https://github.com/material-components/material-components-web/issues/134

maxcan commented 7 years ago

Strong vote here in favor of typescript support. If you're willing, i think migrating to TS is the most sustainable, value adding approach

Hardtack commented 7 years ago

@maxcan I'm doing some research for TypeScript. Maybe It will be migrated to TypeScript if there's no critical problem.

Hardtack commented 7 years ago

flowgen is not capable with our project. I'll consider flow support later

Hardtack commented 7 years ago

Closed by #24