react-native-ar / react-native-arkit

React Native binding for iOS ARKit
MIT License
1.73k stars 139 forks source link

Android/ARCore integration #14

Open DavoCg opened 7 years ago

DavoCg commented 7 years ago

Hello,

I know that the main purpose on this module is to provide a binding for Apple ARKit but today Google released ARCore and I'm wondering if this module will support it for Android devices (and maybe being renamed) ?

Thanks for your amazing work !

macrozone commented 7 years ago

The api looks pretty similar to arkit: https://developers.google.com/ar/reference/java

plane detection and plane-hitdetection should be possible.

Does someone have experience with 3d content on android and could implement the basic primitives (sphere, cube, model, etc.) on android? I have no experience on that unfortunatly

mubaris commented 6 years ago

Will this happen?

pritasam commented 6 years ago

Hey for the time I created a library as per my requirement...and looking forward for improvement

https://github.com/pritasam/react-native-arcore

macrozone commented 6 years ago

That‘s awesome. Could you try to integrate this in this library? There will be some overlapping api that can be unified, some other might be more challenging. But i expect most of the api to be sinilar pritam notifications@github.com schrieb am Fr. 9. Feb. 2018 um 11:10:

Hey for the time I created a sample as per my requirement...and looking forward to improvement

https://github.com/pritasam/react-native-arcore

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/HippoAR/react-native-arkit/issues/14#issuecomment-364391584, or mute the thread https://github.com/notifications/unsubscribe-auth/AB4YgcUSerheF_rtlzNx-GMtYlbLa-GWks5tTBmSgaJpZM4PGMOn .

--

pritasam commented 6 years ago

Yeah sure....I will try to integrate this in the library with improvements with basic primitives like (sphere, cube, model, etc.)

macrozone commented 6 years ago

Would be cool to have the basics!

I will create a board for the roadmap. I think once we have the basics, it will be easier pritam notifications@github.com schrieb am Fr. 9. Feb. 2018 um 11:36:

Yeah sure....I will try to integrate this in the library with improvements with basic primitives like (sphere, cube, model, etc.)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/HippoAR/react-native-arkit/issues/14#issuecomment-364397973, or mute the thread https://github.com/notifications/unsubscribe-auth/AB4YgeNYMDBgp6og52I7phRBUj_svG9Iks5tTB-tgaJpZM4PGMOn .

--

pritasam commented 6 years ago

Thats a good idea 👍

macrozone commented 6 years ago

I created a board: https://github.com/HippoAR/react-native-arkit/projects/1

@pritasam I think we need to start with having the (empty) ArView component on android. After that i would start with some 3d objects like <ARModel />' and`

and the most basic apis like the plane detection.

I expect to see some api differences and we should try to harmonize if possible (It's ok if we have some breaking changes for ios)

Jackyaung commented 6 years ago

Hi does the react-native-arkit also work on Android devices?

After I integrated this framework, it works on iphone but when I try to run on Android device, it report a error, does it means this framework doesn't support android devices ?

Stophface commented 6 years ago

@Jackyaung Nope. ARKit is iOS only. Android's AR Software is called ARCore. ARCore is not implemented in this library yet.