react-native-ar / react-native-arkit

React Native binding for iOS ARKit
MIT License
1.73k stars 139 forks source link

ARKit.snapshot() aliasing #187

Open ambewas opened 6 years ago

ambewas commented 6 years ago

When taking a screenshot with ARKit.snapshot() (or other libraries to capture the viewport), there's a lot of aliasing visible on the 3D models, which is not apparent when viewing the models in the scene live.

Here's a screenshot for reference: img_0006

How would I go about applying anti-aliasing to the models captured in the screenshot?

macrozone commented 6 years ago

the screenshot is taken directly from the current frame as far as i remember. Maybe you don't notice the alasing when its live because of slight movement?

ambewas commented 6 years ago

Yeah, after closer examination the aliasing is indeed present in the live view as well. I started looking for a way to change up (or turn on?) the anti-aliasing as described here - but as far as I can see this library does not expose a setting for that.

I haven't been able to look into your source code much so far, but if you can confirm you don't enable anti-aliasing in this library yet, I'm willing to look into it and submit a PR?