search

react-native-art / art

React Native module that allows you to draw vector graphics.
https://github.com/react-native-community/art
MIT License
287 stars 78 forks source link

ART still present in RN "core" #26

Open jbrodriguez opened 5 years ago

jbrodriguez commented 5 years ago

Question

The Libraries/ART module is still present in FB as of 0.60.4

Some libraries (react-native-progress) depend on it.

Should they move to @react-native-community/art or there was the decision on ART turned around ?

Esemesek commented 5 years ago

Moving ART to this repository is a part of Lean Core effort. The module is already deprecated in React Native Core and you should get a warning message in the console. In one of the future releases, ART will be completely removed from the core.

jeveloper commented 5 years ago

@Esemesek Thanks! Could you clarify that current ART bundled in RN 59,60 is the same as in this repository ? Or is this repo already ahead of those bundled?

Thank you

Esemesek commented 4 years ago

@jeveloper This repo and ART from core are roughly the same. Only some minor refactors were merged.

Monte47 commented 4 years ago

So I have the correct dependency installed and everything works but I still get the warning. Is there any way to remove the warning or do I have to wait until it is removed from react core?

Rotemy commented 4 years ago

So I have the correct dependency installed and everything works but I still get the warning. Is there any way to remove the warning or do I have to wait until it is removed from react core?

I think your project is still using the "old" RN version.

laurentS commented 4 years ago

Sorry to piggyback on this. I am moving an app from RN 0.59.10 to 0.60.6 and I got the following error message Tried to register two views with the same name ARTSurfaceView after I added @react-native-community/art to my dependencies. In yarn.lock I could see that both react-native and this package depend on art. I tried removing @react-native-community/art from my package.json and import ART from react-native, and things work fine. So I'm confused by the status of the Lean Core extraction of ART. The README seems to imply that the community package is already needed from RN 0.60 (even before, in fact). At what point are we supposed to actually make the transition?

Esemesek commented 4 years ago

ART in react-native is deprecated - it was deprecated in 0.60.x but it is still present on the master branch of react-native. You should receive warnings when importing it. It seems like ART is linked a couple of times in your project which causes an error. When using react-native >= 0.60.0 you should use this package.