fix: extractOpacity bug when "visible" is undefined

react-native-art / art

React Native module that allows you to draw vector graphics.

https://github.com/react-native-community/art

MIT License

287 stars 78 forks source link

fix: extractOpacity bug when "visible" is undefined #28

Closed aleclarson closed 5 years ago

aleclarson commented 5 years ago

When the visible prop is undefined, the extractOpacity function should ignore it.

Instead of changing the !visible check to visible === null, I removed it because visible: null is ambiguous, so visible: false should always be preferred.

smacgregor commented 5 years ago

This PR will resolve https://github.com/react-native-community/art/issues/29

Esemesek commented 5 years ago

Thank you for this PR <3