Open jlkalberer opened 4 years ago
Hi guys, when can we expect this to be merged ? I need this fix in my app.
Thanks !
@EvanBacon Sorry to bother you, but could you check this PR really quick ? I feel like this issue is impacting a lot of other librairies, and I need it tbh :D
Thanks !
Yeah, it's weird that they don't fix it themselves or approve this pull request :/
Hey, thanks for the PR. Everything looks good, but it seems that I cannot push to your master branch to fix conflicts. I'll merge this PR when conflicts will be resolved.
@jlkalberer Any ETA on fixing the merge conflicts? Thanks
@jlkalberer Any ETA on fixing the merge conflicts? Thanks
I’m away from a computer until next week. I’m glad this issue is finally getting traction but this PR has been out forever...
I'll have a fix for this today with iOS testing. Be ready to merge :D
I rebased my changes on top of this branch and have tested things again. I've updated the original PR with the new test plan.
Summary
Fixing the issues outlined in https://github.com/react-native-community/art/issues/64
yarn.lock
Test Plan
Ran the example project on iOS and Android
What's required for testing (prerequisites)?
yarn android
What are the steps to reproduce (after prerequisites)?
Verify that the example no longer crashes
Compatibility
Checklist
README.md
CHANGELOG.md
example/App.js
)