react-native-art / art

React Native module that allows you to draw vector graphics.
https://github.com/react-native-community/art
MIT License
287 stars 78 forks source link

Fix Android build #65

Open jlkalberer opened 4 years ago

jlkalberer commented 4 years ago

Summary

Fixing the issues outlined in https://github.com/react-native-community/art/issues/64

Test Plan

Ran the example project on iOS and Android Screen Shot 2020-12-03 at 8 28 39 AM

What's required for testing (prerequisites)?

  1. Clone the repo
  2. run yarn android

What are the steps to reproduce (after prerequisites)?

Verify that the example no longer crashes

Compatibility

OS Implemented
iOS
Android

Checklist

Clonescody commented 4 years ago

Hi guys, when can we expect this to be merged ? I need this fix in my app.

Thanks !

Clonescody commented 4 years ago

@EvanBacon Sorry to bother you, but could you check this PR really quick ? I feel like this issue is impacting a lot of other librairies, and I need it tbh :D

Thanks !

jlkalberer commented 3 years ago

Yeah, it's weird that they don't fix it themselves or approve this pull request :/

Esemesek commented 3 years ago

Hey, thanks for the PR. Everything looks good, but it seems that I cannot push to your master branch to fix conflicts. I'll merge this PR when conflicts will be resolved.

n0490b commented 3 years ago

@jlkalberer Any ETA on fixing the merge conflicts? Thanks

jlkalberer commented 3 years ago

@jlkalberer Any ETA on fixing the merge conflicts? Thanks

I’m away from a computer until next week. I’m glad this issue is finally getting traction but this PR has been out forever...

jlkalberer commented 3 years ago

I'll have a fix for this today with iOS testing. Be ready to merge :D

jlkalberer commented 3 years ago

I rebased my changes on top of this branch and have tested things again. I've updated the original PR with the new test plan.