search

react-native-art / art

React Native module that allows you to draw vector graphics.
https://github.com/react-native-community/art
MIT License
287 stars 78 forks source link

fix(ios): Xcode12 build run on device crash #70

Closed layneios closed 3 years ago

layneios commented 3 years ago

Summary

Fixing the issues outlined in #29721

20200919105840

Reason

Since the ARTShadow structure holds a color object, it will cause a zombie object after destruction.

Test Plan

Ran the example project

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS ✅
Android ✅

Checklist

michbil commented 3 years ago

@lengmolehongyan I have failed to build your fix. Got couple of syntax errors. Is it verified solution you posted?

layneios commented 3 years ago

@lengmolehongyan I have failed to build your fix. Got couple of syntax errors. Is it verified solution you posted?

Yeah, verified, would you mind uploading these build syntax errors?

michbil commented 3 years ago

@lengmolehongyan Never mind, I made error during patch, that's why there was errors. Your fix seems to work fine for me. Thank you!

tsdmrfth commented 3 years ago

I am facing with same issue. When it is planned to merge?

efornaro commented 3 years ago

The patch is good, but merging is blocked. Could anyone with write access approve the changes? Thanks.

v-honcharenko commented 3 years ago

Can this update be released asap?

chakrihacker commented 3 years ago

Please release an update thanks

gustavogialim commented 3 years ago

I've tried to apply this patch and got malformed error, anyone else also had problems with it? image

@michbil maybe is the same problem that you had and solved next, is it?

gustavogialim commented 3 years ago

About the error above I just remove the '100%' on height sizes and worked well, the height prop looks support only numbers.

kadanes commented 3 years ago

Why has this still not been released as part of a new release?