react-native-art / art

React Native module that allows you to draw vector graphics.

https://github.com/react-native-community/art

MIT License

287 stars 78 forks source link

Full ART types extracted from DefinitelyTyped #72

Open steadicat opened 3 years ago

steadicat commented 3 years ago

Summary

The type definitions in this repo are woefully incomplete. Thankfully, DefinitelyTyped types for RN have full types for ART. This copies over the relevant types from https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react-native/index.d.ts.

Fixes #59.

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS	Implemented
iOS	✅
Android	✅

Checklist

[ ] I have tested this on a device and a simulator
[ ] I added the documentation in README.md
[ ] I mentioned this change in CHANGELOG.md
[x] I updated the typed files (TS and Flow)
[ ] I added a sample use of the API in the example project (example/App.js)

nschild commented 3 years ago

@steadicat Looks like it is still missing quite a few typings. Notably rotation on Group, strokeJoin on Shape, but I am sure there are more.

vladkosinov commented 3 years ago

@steadicat ping