search

react-native-async-storage / async-storage

An asynchronous, persistent, key-value storage system for React Native.
https://react-native-async-storage.github.io/async-storage/
MIT License
4.61k stars 459 forks source link

Fails to build on a fresh ARM64 react native windows app #1022

Closed jkoutavas closed 7 months ago

jkoutavas commented 8 months ago

What happened?

What's all this then?

 × Building Solution: C:\Users\jay\.nuget\packages\microsoft.ui.xaml\2.8.0\build\Common.targets(10,5): error : Mi...
 × Build failed with message C:\Users\jay\.nuget\packages\microsoft.ui.xaml\2.8.0\build\Common.targets(10,5): error : Microsoft.UI.Xaml nuget package requires TargetPlatformMinVersion >= 10.0.17763.0 (current project is 16299) [C:\Users\jay\dev\RNWindows\node_modules\@react-native-async-storage\async-storage\windows\ReactNativeAsyncStorage\ReactNativeAsyncStorage.vcxproj]. Check your build configuration.
Command failed. Re-run the command with --logging for more information.

I generated a fresh "RNWindows" app this morning, doing the following:

npx react-native init RNWindows --version "latest"
cd RNWindows
npx react-native-windows-init --overwrite
yarn add @react-native-async-storage/async-storage
npx react-native run-windows --arch arm64

Version

1.19.3

What platforms are you seeing this issue on?

System Information

info Fetching system and libraries information...
System:
  OS: Windows 10 10.0.22621
  CPU: (4) x64 Apple Silicon
  Memory: 3.38 GB / 7.99 GB
Binaries:
  Node:
    version: 18.16.1
    path: C:\Program Files\nodejs\node.EXE
  Yarn:
    version: 1.22.19
    path: C:\Program Files (x86)\Yarn\bin\yarn.CMD
  npm:
    version: 9.7.2
    path: C:\Program Files\nodejs\npm.CMD
  Watchman: Not Found
SDKs:
  Android SDK: Not Found
  Windows SDK:
    AllowDevelopmentWithoutDevLicense: Enabled
    AllowAllTrustedApps: Enabled
    Versions:
      - 10.0.18362.0
      - 10.0.19041.0
      - 10.0.22000.0
      - 10.0.22621.0
IDEs:
  Android Studio: Not Found
  Visual Studio:
    - 17.6.33815.320 (Visual Studio Community 2022)
Languages:
  Java: Not Found
  Ruby: Not Found
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.72.6
    wanted: 0.72.6
  react-native-windows:
    installed: 0.72.17
    wanted: 0.72.17
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found

Steps to Reproduce

On a Windows 10 machine (I use Parallels running on my Apple Silicon MacBook Pro):

npx react-native init RNWindows --version "latest"
cd RNWindows
npx react-native-windows-init --overwrite
yarn add @react-native-async-storage/async-storage
npx react-native run-windows --arch arm64
tido64 commented 7 months ago

Hi, if you're able to, can you give this a go and let us know if it fixes the issue: https://github.com/react-native-async-storage/async-storage/pull/1031

AsyncStorageBot commented 7 months ago

:tada: This issue has been resolved in version 1.21.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: