search

react-native-async-storage / async-storage

An asynchronous, persistent, key-value storage system for React Native.
https://react-native-async-storage.github.io/async-storage/
MIT License
4.61k stars 459 forks source link

Set iOS target to 12.4 for new architecture #1024

Closed hsjoberg closed 7 months ago

hsjoberg commented 8 months ago

Summary

Hey, I assume this was a typo as react-native itself sets 12.4 as the minimum required version. Without this change, you'll get a build error in the default react-native template and configuration.

krizzu commented 7 months ago

yeah, I think it was a typo - @tido64 can you please confirm ?

tido64 commented 7 months ago

I can't recall why I asked for 13.4, but I'm pretty sure it was intentional since I've been telling people to bump their minimum deployment version: https://github.com/react-native-async-storage/async-storage/issues/982#issuecomment-1618938674

It will be default starting with 0.73 though, so we should leave this be: https://github.com/facebook/react-native/commit/610b14e4f3f606cd4c49518b9a42e3290fd52aeb

Are you having specific issues?

hsjoberg commented 7 months ago

I see, I was not aware that react-native 0.73 is going to bump up target to iOS 13.4. Then this change does not make sense moving forward. Closing this one.

Are you having specific issues?

Well, it's easily fixable of course, but the default react-native template \w new arch enabled will fail (<=0.72).