react-native-async-storage / async-storage

An asynchronous, persistent, key-value storage system for React Native.
https://react-native-async-storage.github.io/async-storage/
MIT License
4.61k stars 459 forks source link

chore(android): Bump version for Next storage #1028

Closed krizzu closed 7 months ago

krizzu commented 7 months ago

Summary

krizzu commented 7 months ago

@tido64 Moved the config to separate file, for easier management. I left an option to still be able to override KSP version, in case Kotlin v2 and supporting KSP releases, before we add support for it.

krizzu commented 7 months ago

@tido64 CI is failing due to

Plugin [id: 'com.google.devtools.ksp', version: 'null'] was not found in any of the following sources

I had same issue locally, where dependencies.gradle file could not be read from TestApp.

tido64 commented 7 months ago

@tido64 CI is failing due to

Plugin [id: 'com.google.devtools.ksp', version: 'null'] was not found in any of the following sources

I had same issue locally, where dependencies.gradle file could not be read from TestApp.

Seems like we're missing the latest version: https://github.com/microsoft/react-native-test-app/pull/1701

I've also updated the logic to not return null.

Update: Can you try bumping to 2.5.33?

krizzu commented 7 months ago

Bumped, let's give it a go 🤞

tido64 commented 7 months ago

Looks like we need to bump Robolectric:

com.reactnativecommunity.asyncstorage.next.AsyncStorageAccessTest > initializationError FAILED
    java.lang.IllegalArgumentException: failed to configure com.reactnativecommunity.asyncstorage.next.AsyncStorageAccessTest.performsBasicGetSetRemoveOperations: Package targetSdkVersion=33 > maxSdkVersion=31
        at org.robolectric.RobolectricTestRunner.getChildren(RobolectricTestRunner.java:260)

Latest version should support up to 34.

krizzu commented 7 months ago

~Yeah, will try to do it later day or tomorrow 🙏~ Done

krizzu commented 7 months ago

@tido64 added a log to it. I'm going to release this as minor version update, due to libraries bump

AsyncStorageBot commented 7 months ago

:tada: This PR is included in version 1.20.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: