react-native-async-storage / async-storage

An asynchronous, persistent, key-value storage system for React Native.
https://react-native-async-storage.github.io/async-storage/
MIT License
4.61k stars 458 forks source link

ReactNative 0.74 remove internal references of onCatalystInstanceDestroy #1106

Open JinYuSha0 opened 1 week ago

JinYuSha0 commented 1 week ago

What happened?

Compilation error Overrides method that is deprecated and marked for removal in 'com.facebook.react.bridge.NativeModule' Related PR: https://github.com/facebook/react-native/pull/41835/files onCatalystInstanceDestroy it has no actual effect anymore

Version

1.23.1

What platforms are you seeing this issue on?

System Information

System:
  OS: Windows 10 10.0.19045
  CPU: (6) x64 Intel(R) Core(TM) i5-9400 CPU @ 2.90GHz
  Memory: 2.96 GB / 15.88 GB
Binaries:
  Node:
    version: 20.13.1
    path: C:\Program Files\nodejs\node.EXE
  Yarn:
    version: 4.3.1
    path: C:\Program Files\nodejs\yarn.CMD
  npm:
    version: 10.5.2
    path: C:\Program Files\nodejs\npm.CMD
  Watchman: Not Found
SDKs:
  Android SDK: Not Found
  Windows SDK:
    AllowDevelopmentWithoutDevLicense: Enabled
    AllowAllTrustedApps: Enabled
IDEs:
  Android Studio: AI-233.14808.21.2331.11709847
  Visual Studio: Not Found
Languages:
  Java: 17.0.11
  Ruby: Not Found
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.74.2
    wanted: 0.74.2
  react-native-windows: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found

Steps to Reproduce

upgrade react-native to version 0.74.2