n1ru4l commented 5 years ago

Feature-Request

Describe the Feature

I am developing an app that records videos in the portrait mode. Therefore I force the orientation Portrait mode with the following code:

const options = {
  ...remainingOptions,
  orientation: 1
};

const result = await camera.recordAsync(options);

However I need to know the actual deviceOrientation when the video recording started on the JS Thread.

Possible Implementations Expose a new property deviceOrientation on the result returned by camera.recordAsync(options). This property includes the actual orientation of the device. Furthermore for integrity we can also add the videoOrientation property to the result.

@sibelius Are you okay with me implementing this feature?

const options = {
  ...remainingOptions,
  orientation: 1
};

const result = await camera.recordAsync(options);
console.log(result.videoOrientation, result.deviceOrientation);

Love react-native-camera? Please consider supporting our collective: 👉 https://opencollective.com/react-native-camera/donate Want this feature to be resolved faster? Please consider adding a bounty to it https://issuehunt.io/repos/33218414

sibelius commented 5 years ago

I think we can provide this

n1ru4l commented 5 years ago

:tada: This issue has been resolved in version 1.6.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

react-native-camera / react-native-camera

include deviceOrientation and orientation in RecordResponse #1983

Feature-Request