search

react-native-clipboard / clipboard

React Native Clipboard API for both iOS and Android.
MIT License
690 stars 142 forks source link

Remove explicit SDK version for Windows builds #177

Closed chrisglein closed 1 year ago

chrisglein commented 1 year ago

Overview

Fix SDK build error if 10.0.18362.0 is not installed:

× Building Solution: C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Microsoft\VC\v170\Microsoft...
× Build failed with message C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Microsoft\VC\v170\Microsoft.Cpp.WindowsSDK.targets(46,5): error MSB8036: The Windows SDK version 10.0.18362.0 was not found. Install the required version of Windows SDK or change the SDK version in the project property pages or by right-clicking the solution and selecting "Retarget solution".

See https://github.com/react-native-async-storage/async-storage/pull/810 for a similar fix.

Previously, after bringing down package dependencies you'd have to retarget the SDK version for the module project.

Test Plan

Committed to a fork and redirected an app with a Windows build to this. Build error goes away.