react-native-clipboard / clipboard

React Native Clipboard API for both iOS and Android.
MIT License
690 stars 142 forks source link

Error to Deploy to Android RN 0.73.2 #225

Open MplanSdrigues opened 6 months ago

MplanSdrigues commented 6 months ago

Environment

System: OS: macOS 14.4 CPU: (8) arm64 Apple M2 Memory: 82.11 MB / 8.00 GB Shell: version: "5.9" path: /bin/zsh Binaries: Node: version: 20.11.1 path: /var/folders/tz/kxc2bv_d2gqgwn1ssc_6qkc80000gn/T/yarn--1710974312753-0.10428707950275529/node Yarn: version: 1.22.21 path: /var/folders/tz/kxc2bv_d2gqgwn1ssc_6qkc80000gn/T/yarn--1710974312753-0.10428707950275529/yarn npm: version: 10.2.4 path: /usr/local/bin/npm Watchman: version: 2024.01.22.00 path: /opt/homebrew/bin/watchman Managers: CocoaPods: version: 1.15.2 path: /usr/local/bin/pod SDKs: iOS SDK: Platforms:

Platforms

This issue occurs on Android when running ./gradlew bundleRelease

Versions

Description

when you running ./gradlew bundleRelease to build an .aab app, occored this error

image

Reproducible Demo

chinNuttawot commented 6 months ago

 me too

edritech93 commented 6 months ago

same for me

Parathantl commented 6 months ago

same for me

nguyenductoan1995 commented 6 months ago

Is there a way to solve this problem yet, everyone?

mykhailoperemitko commented 6 months ago

Hey all!

I patched ClipboardModule.java to make it compatible with the latest changes in RN. Seems to work fine for now.

diff --git a/node_modules/@react-native-community/clipboard/android/src/main/java/com/reactnativecommunity/clipboard/ClipboardModule.java b/node_modules/@react-native-community/clipboard/android/src/main/java/com/reactnativecommunity/clipboard/ClipboardModule.java
index 4ecb0cb..b664b3c 100644
--- a/node_modules/@react-native-community/clipboard/android/src/main/java/com/reactnativecommunity/clipboard/ClipboardModule.java
+++ b/node_modules/@react-native-community/clipboard/android/src/main/java/com/reactnativecommunity/clipboard/ClipboardModule.java
@@ -11,7 +11,9 @@ import android.content.ClipboardManager;
 import android.content.ClipData;
 import android.content.Context;

-import com.facebook.react.bridge.ContextBaseJavaModule;
+import com.facebook.react.bridge.ReactApplicationContext;
+import com.facebook.react.bridge.ReactContext;
+import com.facebook.react.bridge.ReactContextBaseJavaModule;
 import com.facebook.react.bridge.ReactMethod;
 import com.facebook.react.bridge.Promise;
 import com.facebook.react.module.annotations.ReactModule;
@@ -20,10 +22,13 @@ import com.facebook.react.module.annotations.ReactModule;
  * A module that allows JS to get/set clipboard contents.
  */
 @ReactModule(name = ClipboardModule.NAME)
-public class ClipboardModule extends ContextBaseJavaModule {
+public class ClipboardModule extends ReactContextBaseJavaModule {
+  private Context context;

-  public ClipboardModule(Context context) {
+  public ClipboardModule(ReactApplicationContext context) {
     super(context);
+
+    this.context = context;
   }

   public static final String NAME = "RNCClipboard";
@@ -34,7 +39,7 @@ public class ClipboardModule extends ContextBaseJavaModule {
   }

   private ClipboardManager getClipboardService() {
-    return (ClipboardManager) getContext().getSystemService(getContext().CLIPBOARD_SERVICE);
+    return (ClipboardManager) context.getSystemService(Context.CLIPBOARD_SERVICE);
   }

   @ReactMethod
andriiradkevych commented 5 months ago

@Naturalclar isn't it the same https://github.com/react-native-clipboard/clipboard/issues/238

@mykhailoperemitko can you check ?