fix: readConfigFromDisk should ignore package.json entries

react-native-community / cli

The React Native Community CLI - command line tools to help you build RN apps

MIT License

2.41k stars 905 forks source link

fix: readConfigFromDisk should ignore package.json entries #2472

Closed vonovak closed 3 months ago

vonovak commented 3 months ago

Summary:

I was trying out 0.75 and not sure why is worked before, but now the config command returned this value - literally "src/index", instead of the value influenced by the config file.

Test Plan:

npx react-native config returned a valid result in the repo

Checklist

[ ] Documentation is up to date to reflect these changes.
[x] Follows commit message convention described in CONTRIBUTING.md

thymikee commented 3 months ago

@szymonrybczak mind looking at it? I'm not sure why we haven't used searchPlaces param for reading from disk.

vonovak commented 3 months ago

It was there before, but was removed with https://github.com/react-native-community/cli/pull/2343/files Looks like a mistake to me?