react-native-community / cli

The React Native Community CLI - command line tools to help you build RN apps
MIT License
2.41k stars 905 forks source link

Put an upper bound on "**/Podfile" search depth #2480

Closed ephemer closed 3 months ago

ephemer commented 3 months ago

Summary:

This PR addresses https://github.com/react-native-community/cli/issues/2479. Basically the unbounded search for **/Podfile never finishes on my machine. Normally the required depth should be 2, since ios/Podfile is the default location. So this still provides significantly more depth than most users should need.

Test Plan:

To be honest I'm not sure what causes this issue on my system, I only investigated what fixes it so far. It's clearly an issue with a deeply-nested submodule that we have, but I can't see what about it is causing the issue. If I run find . in my project root, all files (including the deeply-nested ones) can be printed within a few seconds, whereas fast-glob appears to never finish its search without this deep: 10 limitation.

Checklist

thymikee commented 3 months ago

Thanks! Can you file that in fast-glob project as well so they can hopefully fix this?