react-native-community / cli

The React Native Community CLI - command line tools to help you build RN apps
MIT License
2.41k stars 905 forks source link

chore: remove deprecated --npm flag #2504

Closed TMisiukiewicz closed 2 months ago

TMisiukiewicz commented 2 months ago

Summary:

The --npm flag in init command has been deprecated for more than a year now in favor of using --pm flag. Since npm will become a default package manager when initializing new project (#2503), I think it's a good time to remove this flag.

Test Plan:

  1. Run init command locally and use --npm flag
  2. Verify error is displayed:
    error: unknown option '--npm'
    (Did you mean --pm?)

Checklist

thymikee commented 2 months ago

@cortinico this is a small braking change that shouldn't affect too many users, shall we ship it as a part of 0.76 and document in the changelog?

szymonrybczak commented 2 months ago

@cortinico this is a small braking change that shouldn't affect too many users,

To give more context, this option was deprecated with appropriate warning for 3 major versions already.

cortinico commented 2 months ago

@cortinico this is a small braking change that shouldn't affect too many users, shall we ship it as a part of 0.76 and document in the changelog?

Yup this sounds reasonable 👍