search

react-native-community / directory

A searchable and filterable directory of React Native libraries.
https://reactnative.directory
MIT License
1.06k stars 504 forks source link

The library contains built-in Typescript declarations, it's not marked with TS on Directory #1286

Closed RakaDoank closed 1 month ago

RakaDoank commented 1 month ago

Hi, thanks for adding my library, even it's currently hottest trending when i wrote this issue.

My library is not marked with [TS] Typescript Types, even the library contains built-in TS declarations. Meanwhile, my other library is correctly marked with the [TS] Typescript Types.

Is this because the githubUrl i added to the react-native-libraries.json (this commit) using the repository url (homepage) instead of the literally library/package itself (such as https://github.com/RakaDoank/react-native-ping-android/tree/main/package)? If it's true, i might create a new PR. Otherwise, any alternatives that i can follow?

Simek commented 1 month ago

Hello @RakaDoank, you have correctly identified the problem. Your repository is setup as monorepo, and in those cases githubUrl need to point to the directory where package.json for the library resides.

Feel free to create a PR correcting that, this should resolve the missing TS types flag.