search

react-native-community / docker-android

Android Docker Image for React Native and common android development.
MIT License
479 stars 144 forks source link

Add Fastlane to separate Dockerfile #114

Closed avegrv closed 3 years ago

avegrv commented 3 years ago

I would like to suggest add Fastlane support.

Nowadays Fastlane is a popular tool for the distribution of Apk/ISO files and other CI/CD tasks.

We can extend or create a new Dockerfile with Fastlane support.

Also, I already have a repository for building react-native apps with Fastlane https://github.com/avegrv/react-native-docker

gengjiawen commented 3 years ago

You can easily integrate with current docker. Introduce too much tools can easily make this image bloated.

FROM reactnativecommunity/react-native-android
RUN gem install fastlane
avegrv commented 3 years ago

@gengjiawen In your approach, I need to install Fastlane every time when I start a CI job, it can slow down the time of execution.

gengjiawen commented 3 years ago

@gengjiawen In your approach, I need to install Fastlane every time when I start a CI job, it can slow down the time of execution.

Not everyone needs fastlane.

I need to install Fastlane every time when I start a CI job

You can publish your image on dockerhub.