search

react-native-community / docker-android

Android Docker Image for React Native and common android development.
MIT License
486 stars 144 forks source link

Bump node version #187

Closed krudos closed 1 year ago

krudos commented 1 year ago

Bump node version to 16.x as defined in .node-version in react native

cortinico commented 1 year ago

This was discussed here: https://github.com/react-native-community/docker-android/issues/172#issuecomment-1143622018

I'm unsure if we want to bump Node to 16 at this stage as we won't be testing on 14 anymore. But as 18 entered LTS, it's probably worth to switch at this stage

krudos commented 1 year ago

current version of react native support node 16 https://github.com/facebook/react-native/blob/main/.node-version also this tool that is use to build react native packages needs node 16 https://github.com/callstack/react-native-builder-bob

so it will be great if this could be merge

gengjiawen commented 1 year ago

I am inclined we directly bump to 18

krudos commented 1 year ago

I change it to 18

cortinico commented 1 year ago

I am inclined we directly bump to 18

I would stick to 16 actually as historically we broke builds for people on previous versions of Node if we don't run on the min supported

gengjiawen commented 1 year ago

I am inclined we directly bump to 18

I would stick to 16 actually as historically we broke builds for people on previous versions of Node if we don't run on the min supported

Node.js 16 will EOL in 2023. 18 will in 2025 with more features and newer v8 (comprehensive js features). As for old user, they can still use tagged Image as a workaround.

Also if https://github.com/react-native-community/docker-android/pull/188 got merged, they can use n to switch node version easily.

cortinico commented 1 year ago

As this got merged: https://github.com/facebook/react-native/pull/35443

Please go ahead and bump to 16.x

If you need 18 -> Let's merge #188 instead

krudos commented 1 year ago

As this got merged: facebook/react-native#35443

Please go ahead and bump to 16.x

If you need 18 -> Let's merge #188 instead

you mean bump to 18.x ?

cortinico commented 1 year ago

you mean bump to 18.x ?

Nope, I meant bump to 16.x To clarify again:

I would stick to 16 actually as historically we broke builds for people on previous versions of Node if we don't run on the min supported

We want the docker container to run on the minimum supported version of Node, which was bumped from 14 -> 16.