search

react-native-community / docker-android

Android Docker Image for React Native and common android development.
MIT License
482 stars 144 forks source link

Bump Release for Node 18.20 Memory Leak fix #219

Open TiKevin83 opened 6 months ago

TiKevin83 commented 6 months ago

We use this image for CI builds of React Native, can we bump out a release to use at least Node 18.20? I'm getting 18.19 in my CI pipeline and there's a critical fix in 18.20 for a memory leak in Jest tests that has been out there for 2.5 years and requiring running Jest with --workerIdleMemoryLimit set to a low number like 100mb to prevent OOMs in the CI runner.

https://github.com/jestjs/jest/issues/11956 https://nodejs.org/en/blog/release/v18.20.0#vm-fix-v8-compilation-cache-support-for-vmscript

TiKevin83 commented 4 months ago

@cortinico @tuncaulubilge are you able to rebuild and redeploy the image to get this resolved?

cortinico commented 4 months ago

Please send a PR that bumps the Node version and if the CI is green we can merge it

TiKevin83 commented 4 months ago

Please send a PR that bumps the Node version and if the CI is green we can merge it

As far as I see the Node version is only specific to the major version 18, just I just go ahead and PR bumping it to the active LTS 20?

cortinico commented 4 months ago

As far as I see the Node version is only specific to the major version 18, just I just go ahead and PR bumping it to the active LTS 20?

Nope we can't bump Node to 20 as of now. We'll have to bump it to 18.20 and make sure that the download script keeps on working correctly.

TiKevin83 commented 4 months ago

Ok I see the N script should be able to handle 18.20 vs 18 - PRed here https://github.com/react-native-community/docker-android/pull/225