search

react-native-community / docker-android

Android Docker Image for React Native and common android development.
MIT License
486 stars 144 forks source link

Update to Node 18.20 for Memory Leak Fix #225

Closed TiKevin83 closed 5 months ago

TiKevin83 commented 5 months ago

Updating to Node 18.20 will fix a memory leak regression that has been affecting Jest for a while, see here for references:

https://github.com/jestjs/jest/issues/11956

https://github.com/nodejs/node/pull/51004

TiKevin83 commented 5 months ago

@cortinico suggestions on the failed circleci build?

cortinico commented 5 months ago

@cortinico suggestions on the failed circleci build?

The CI failed because the build took more than 1 hour to complete. In order to merge this we'll have fix the CI by either:

cortinico commented 5 months ago

see also https://github.com/react-native-community/docker-android/issues/226

TiKevin83 commented 5 months ago

@cortinico started testing a fix for #226 in #227 - it looks like the publish already has a GitHub actions workflow so it just needed the build half ported

cortinico commented 5 months ago

@TiKevin83 amazing so can you rebase this PR and we can merge it afterwards 👍

TiKevin83 commented 5 months ago

@TiKevin83 amazing so can you rebase this PR and we can merge it afterwards 👍

done - you may also want to remove the CircleCI integration that's still showing up on these PR checks

cortinico commented 5 months ago

done - you may also want to remove the CircleCI integration that's still showing up on these PR checks

Yeah I already disabled it but for some reason it keep getting re-enabled