search

react-native-community / react-native-circleci-orb

A CircleCI Orb to Simplify Testing your React Native App
MIT License
176 stars 80 forks source link

feat: add parameter to allow configuring the android tests on build #101

Closed kieran-osgood closed 3 years ago

kieran-osgood commented 3 years ago

Adds a parameter to #100 where android builds will fail at the assembleAndroidTest portion due to minSdkVersion in react-native 0.64 increasing from 16 to 21, meaning that dependencies such as react-native-splash-screen error

ribamarsantos commented 3 years ago

Hey Folks, I was setting up a new env and trying to use the orbs for the first time and got this same issue. Do we have an idea when this PR will be merged ? Thanks in advance.

kieran-osgood commented 3 years ago

Hey Folks, I was setting up a new env and trying to use the orbs for the first time and got this same issue. Do we have an idea when this PR will be merged ? Thanks in advance.

Until this is merged, incase it helps anyone, if you can't use the orb because if this issue then using https://circleci.com/developer/orbs/orb/circleci/android it becomes quite a lot easier to get your tests running

matt-oakes commented 3 years ago

Thanks for this!

I have merged this via 0569d663ea9022a146f554277b5f61f3e8704dda with a small tweak to the values that are accepted by this parameter to make it slightly more flexible.

Thanks again!

matt-oakes commented 3 years ago

This was released in v5.2.0.

ribamarsantos commented 3 years ago

Thanks guys. Yeah @kieran-osgood I used to use this one for other projects but since I saw this one from the community I decided to use it since it's everything there. Thanks for the quick response and merge @matt-oakes