search

react-native-community / react-native-circleci-orb

A CircleCI Orb to Simplify Testing your React Native App
MIT License
175 stars 81 forks source link

fix: quote cache keys that start with special characters #143

Closed fotos closed 2 years ago

fotos commented 2 years ago

Description

Quick follow up on #142 which broke the build.

Added single quotes around cache keys that start with special characters such as {{.

Fixes:

circleci config pack src/ > packed-orb.yml

Error: Failed trying to marshal the tree to YAML : yaml: line 22: did not find expected '-' indicator

Tested with:

➜  circleci config pack src > packed-orb.yml
➜  circleci orb validate packed-orb.yml
Orb at `packed-orb.yml` is valid.

Hopefully this does the trick. 🤞 Unfortunately I have no way to actually test it.

fotos commented 2 years ago

By the way, I think the CircleCI workflow doesn't run for forked pull requests.

There is a setting in CircleCI project settings:

build-forked-pull-requests

Maybe it should be enabled? If the pack job run it would have caught the syntax error before merging.

react-native-community-bot commented 2 years ago

:tada: This PR is included in version 6.8.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: