search

react-native-community / react-native-circleci-orb

A CircleCI Orb to Simplify Testing your React Native App
MIT License
174 stars 81 forks source link

feat(node): bump from node 12 to node 16 default #156

Closed mikehardy closed 2 years ago

mikehardy commented 2 years ago

node 12 is out of support I think (?), and node v16 is known to work with react-native, I hope it's mostly backwards compatible and this is okay?

Either way, it was needed as an override for the semantic-release package which just dropped support for 12 and works with 16 now - https://github.com/react-native-share/react-native-share/pull/1218

Not sure if this is a breaking change or not, as I'm unsure of backwards compatibility status

cortinico commented 2 years ago

I hope it's mostly backwards compatible and this is okay?

Ideally moving to 14 would be preferrable, but as this is the orb code, 16 should also work. Potentially using lts here is more maintainable in the long run, but also exposes to version bumps out of control, so the version you picked is probably the correct one 👍

mikehardy commented 2 years ago

With 18 already out 14 seemed too low (as long as it is moving...) but I did want a fixed version for control yes. So I settled on 16 a bit uneasily as well yes

mikehardy commented 2 years ago

@cortinico I found references to 12 in 5 other places after seeing it still failing over on https://github.com/react-native-share/react-native-share/pull/1218

I added commits for the same, should squash-merged if acceptable

cortinico commented 2 years ago

I added commits for the same, should squash-merged if acceptable

Code looks fine to me. The CI is failing though, I believe due to an expired CircleCI token.

mikehardy commented 2 years ago

I don't think I can do anything about a failed CIrcleCI token :sweat_smile: We are overriding node_version locally as a param on this orb for react-native-share and I can attest that it's working for us in practice at v16 with a semi-old version of react-native now:

"react-native": "0.66.4",

https://github.com/react-native-share/react-native-share/blob/10e2b3a9a798e93e1dfc85c9620f72efddfad222/package.json#L48

react-native-community-bot commented 2 years ago

:tada: This PR is included in version 7.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: