search

react-native-community / react-native-circleci-orb

A CircleCI Orb to Simplify Testing your React Native App
MIT License
174 stars 81 forks source link

Added a shell check orb #159

Closed szandany closed 2 years ago

szandany commented 2 years ago

Hello, My name is Tsvi and I am from the CircleCI team! Added a shell check orb to your config.yml so that it will automatically find bugs and errors in your shell scripts with ShellCheck on every commit. Add this static analysis tool/orb to any CI/CD workflow and ShellCheck your scripts across your repository.

cortinico commented 2 years ago

My name is Tsvi and I am from the CircleCI team!

Can you please provide proof of this (i.e. being member of the CircleCI org or so)?

Added a shell check orb to your config.yml so that it will automatically find bugs and errors in your shell scripts with ShellCheck on every commit. Add this static analysis tool/orb to any CI/CD workflow and ShellCheck your scripts across your repository.

According to the official documentation (https://circleci.com/developer/orbs/orb/circleci/shellcheck) this is not correctly configured (as you need to invoke shellcheck/check)

szandany commented 2 years ago

Thanks for the notes, @cortinico I committed another change to add the shellcheck to the workflow as a job. Please see the above commit. I am going to send you an email verification via my circleci email domain as a proof that I am a member of the CircleCI team. :-)

cortinico commented 2 years ago

Also I've realized we don't have any .sh file to lint so this step is probably useless