search

react-native-community / react-native-circleci-orb

A CircleCI Orb to Simplify Testing your React Native App
MIT License
174 stars 81 forks source link

fix: remove _JAVA_OPTIONS parameter & environment #172

Closed devnev closed 3 months ago

devnev commented 1 year ago

Users should set org.gradle.jvmargs in their gradle.properties instead. This fixes #171 where build failures caused by the unexpected output from java commands.

BREAKING CHANGE: The java_options parameter has been removed. Specify your JVM options in the gradle.properties file or in the gradle_options with -Dorg.gradle.jvmargs= instead.

devnev commented 1 year ago

Have checked

./scripts/pack.sh && circleci orb validate packed-orb.yml
Orb at `packed-orb.yml` is valid.
devnev commented 1 year ago

Indeed. Is there anything else worth updating as part of a breaking change? Could bump the default for build_image_version, node_version, xcode_version.

devnev commented 1 year ago

Also worth noting for this PR that UseContainerSupport is enabled by default

devnev commented 1 year ago

Do I need to do anything so that the semver bot understands the breaking change?

cortinico commented 1 year ago

Do I need to do anything so that the semver bot understands the breaking change?

Yup we use semantic-release: https://semantic-release.gitbook.io/semantic-release/v/beta/

So your PR/Commit message should be updated

bhandanyan-nomad commented 3 months ago

Can this PR get merged?

react-native-circleci-orb-bot commented 3 months ago

:tada: This PR is included in version 8.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: