Closed cortinico closed 7 months ago
@cortinico
What's pending in this PR:
master
was triggering a new release, using semantic-release
. This doesn't exist in the current default flow from the template. Need a bit more effort to get this done.orb-publishing
context. Do we need to delete the current environment variables from the project settings (CIRCLECI_API_TOKEN
and GH_TOKEN
)? What can be improved in the PR:
yarn_install
only.
- A way to trigger a release. Previously merging into
master
was triggering a new release, usingsemantic-release
. This doesn't exist in the current default flow from the template. Need a bit more effort to get this done.
According to documentation releases are triggered whenever we publish a new tag/release no? https://circleci.com/docs/creating-orbs/
I don't think we need any token or so setup
- A way to trigger a release. Previously merging into
master
was triggering a new release, usingsemantic-release
. This doesn't exist in the current default flow from the template. Need a bit more effort to get this done.According to documentation releases are triggered whenever we publish a new tag/release no? https://circleci.com/docs/creating-orbs/
I don't think we need any token or so setup
I also believe the tokens, which currently exist in the CircleCI environment, can be removed.
What I'm taking about above is something different. If you look at the documentation closely it says:
To publish a new version of our orb, you need to tag your release. A tag can be created and pushed manually, however we recommend using GitHub.com’s Releases feature.
Basically the orb publishing guide suggests triggering a release "manually" through the GH UI. Currently the project supports semantic-release
which also updates the changelog and creates the GH release. I think we should maintain that.
All in all the flow should be:
main
triggers a CI/CD release which uses semantic-release
to create a new tagorb-tools/publish
workflow based on the filters
.That way merging into main
will automatically trigger a release which will update the tag, the changelog, the GH release, and finally trigger the publish workflow. I believe that's the way forward. I'll get this done later today.
That way merging into
main
will automatically trigger a release which will update the tag, the changelog, the GH release, and finally trigger the publish workflow. I believe that's the way forward. I'll get this done later today.
Yup that sounds reasonable to me 👍
:tada: This PR is included in version 7.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
Adapted from https://github.com/CircleCI-Public/Orb-Template
Skipped a few best practices:
Note: RC007 is skipped because there is no
home_url
present in@orb.yml
(source)