ios: fix project.pbxproj to work on Apple M1

react-native-community / react-native-template-typescript

👾 Clean and minimalist React Native template for a quick start with TypeScript.

https://www.npmjs.com/package/react-native-template-typescript

MIT License

1.86k stars 397 forks source link

ios: fix project.pbxproj to work on Apple M1 #224

Closed barbieri closed 2 years ago

barbieri commented 2 years ago

$(TOOLCHAIN_DIR)/usr/lib/swift-5.0/$(PLATFORM_NAME) is buggy on ARM64 (M1) as it's only built for i386 + x86_64.

Then we must not include it, instead we should use $(SDKROOT)/usr/lib/swift.

This allows us to keep the native arm64 emulator.

Closes: #223

References:

https://github.com/facebook/react-native/commit/a1c445a39c580037ada4a5d194a0d2daef15a25a

radko93 commented 2 years ago

Hey, thanks for the PR. As a M1 user I understand we want to get support ASAP, but we cannot merge template changes into this template as we risk being out of sync with the main template. The only purpose of this template is too add Typescript tooling. Unfortunately this commit will find its way here when it gets released with a stable RN version (probably in RN 0.67).

barbieri commented 2 years ago

but just notice you're out of sync with 0.66, there it contains the $(SDKROOT) part

radko93 commented 2 years ago

We update the template for the stable version, so it will be here as soon as 0.66 is out.