search

react-native-community / releases

React Native releases
https://github.com/facebook/react-native/
1.5k stars 405 forks source link

0.59.x Discussion #100

Closed grabbou closed 5 years ago

grabbou commented 5 years ago

Conversation on this thread are limited to 0.59.0 release's major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.59 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.59-stable branch yourself, in order to ensure that the process proceeds smoothly.

gtebbutt commented 5 years ago

Just missed the 0.59.0 cutoff, but could we cherry-pick https://github.com/facebook/react-native/commit/d834197746371b203bd7d7aaabdc2bc581acc867 please? It fixes the build on tvOS.

grabbou commented 5 years ago

Is tvOS build completely not working w/o this commit? Otherwise, I'd wait a couple of days to see if there are any other commits to include too.

gtebbutt commented 5 years ago

At least with the standard Xcode settings, it's a complete build failure (although the message describes it as a warning, there doesn't seem to be an option to ignore or override it).

That said, Xcode also prompts to fix the file in-place and it's easy enough to add those two lines - and honestly, given the small percentage of us using it on tvOS anyway, I wouldn't personally be worried about another few days.

chr4ss1 commented 5 years ago

Can we get https://github.com/facebook/react-native/commit/fd954cda55b1f87d38bba7f42242163ecee78c35#diff-cf283d7cedacde5bd58c86627558a89c in?

we use TextInput with multiple lines and custom lineheight, the placeholder is not respecting lineheight currently having funky user experience.

cjroth commented 5 years ago

We should add a note to the documentation / website / blog that upgrading requires first updating RN in npm/yarn and then running react-native upgrade --legacy. Otherwise you'll get an error that react-native is already 0.59 and it won't upgrade.

hramos commented 5 years ago

@cjroth I just updated the blog post with some notes around the upgrade process (https://github.com/facebook/react-native-website/pull/828). Can you send a PR if you think that new section needs clarification?

cjroth commented 5 years ago

Nice. Blog makes sense, I'll try to find time to make a PR for the Docs.

I also just noticed that the metro debugger UI is 404ing (localhost:8081/debugger-ui/). Does it need to be specifically enabled now? If so we should document that as well.

grabbou commented 5 years ago

@cjroth we have just fixed that inside CLI. Reinstall node_modules's and you are good to go.

grabbou commented 5 years ago

@ChrisEelmaa the commit you linked depends on another one (https://github.com/facebook/react-native/commit/65c014d19f933771a69c7cbccdbb744330cf13a3), which adds a new feature rather than fixing a bug. Would you be okay trying 0.60 in a couple of days instead?

zhongwuzw commented 5 years ago

Please cherry-pick this https://github.com/facebook/react-native/commit/4aa731ae76b0c764d6c3a9ee19cb516f54da3284 to fix x86_64 build.

suther commented 5 years ago

Would be great, if this would be fixed: https://github.com/facebook/react-native/issues/23342

yurykorzun commented 5 years ago

After updating to 0.59.1 I can no longer debug on Android, because generated source maps are off. Everything works well on iOS. Could it be that updated JSC messed it up?

hramos commented 5 years ago

@suther that's a link to a pull request opened before 0.59 was cut. We're only tracking cherry-pick requests for commits that are already in master.

sunnylqm commented 5 years ago

Please cheery pick https://github.com/facebook/react-native/commit/845189c17de621cc5aa373503220c1c12f649c3c

dulmandakh commented 5 years ago

Cherry picks:

mjmasn commented 5 years ago

Just a heads up for anyone concerned there appears to be a fairly major issue with <TouchableNativeFeedback /> in 0.59 if you use onLongPress.

https://github.com/facebook/react-native/issues/24001

bdrobinson commented 5 years ago

I don't think this is in any 0.59.x release yet but would be great to have if possible – fixing a bug where refresh control on ios gets stuck in a particular state and then stops being interactive: https://github.com/facebook/react-native/commit/95d399bc825c5471e08b83eff4b1b1b510e384a0

adrianha commented 5 years ago

Hi, Please cherry pick https://github.com/facebook/react-native/commit/e38be82dfa8b49385b990629318f027de26500cf to solve broken single line text input when typing text reverts to default value

EDIT from @kelset : removed the gif

dulmandakh commented 5 years ago

cherry pick:

grabbou commented 5 years ago

Thanks for the request. I am going to look into them and release a new version either today or tomorrow.

danilobuerger commented 5 years ago

Please cherry pick:

jsamr commented 5 years ago

Please cherry pick:

guhungry commented 5 years ago

Please cherry pick

RWOverdijk commented 5 years ago

As referenced, https://github.com/facebook/react-native/pull/23585 would be great which fixes https://github.com/facebook/react-native/issues/24087

grabbou commented 5 years ago

Since we have decided to postpone 0.60 release over a week, I am going to do cherry-picking today and release a new version.

ajsmth commented 5 years ago

i can't seem to find which version this was merged into: https://github.com/facebook/react-native/pull/23446 would fix code-push image problems!

grabbou commented 5 years ago

@andyboythekid - it's not part of any of the releases yet. You can check the associated commit to this PR and you'll see it says "master", which means it's not part of any of the branches.

grabbou commented 5 years ago

Finished cherry-picking for 0.59.2. The build is now on the CircleCI. I'll check its status in a few hours.

ajsmth commented 5 years ago

@andyboythekid - it's not part of any of the releases yet. You can check the associated commit to this PR and you'll see it says "master", which means it's not part of any of the branches.

from what i can tell, this update is actually in 0.59.1, at least its working after upgrading for me! thanks!

grabbou commented 5 years ago

The release is ready to go. However, since it’s Friday, let’s wait till Monday morning to release it.

grabbou commented 5 years ago

0.59.2 is on CircleCI. Will hit npm in around 30 minutes.

sunnylqm commented 5 years ago

Please cherry pick https://github.com/facebook/react-native/commit/9db347fabca19c66f669faf4054c81cc3624be03

kelset commented 5 years ago

This would be good to cherry pick too https://github.com/facebook/react-native/commit/c13f5d48cfe3e7c0f6c6d0b745b50a089d6993ef

and this too https://github.com/facebook/react-native/commit/f149426c832a37276bde37e1632c22ba65c5f078

radeno commented 5 years ago

My two cents:

kelset commented 5 years ago

hey everyone - I've cherry-picked most of the requests, and CI is green. Expect 0.59.3 later today or tomorrow.

grabbou commented 5 years ago

Can you outline @kelset what commits you have not cherry-picked? Would help to maintain this thread and also see what we can do with them (reject, ask authors to send a PR, see if they depend on another commit that can easily resolve the conflict).

kelset commented 5 years ago

Sure - sorry I totally forgot: I've cherry picked

And I've added on top

Which should fix some issues devs are experiencing in Swift.

I couldn't cherry pick the others.

I'm waiting on CI to be green again after the last cherry pick, then I'll do the bump.

Bardiamist commented 5 years ago

Why https://github.com/facebook/react-native/commit/56679ed359834c2177c8837d744cc7bf2ceb6b0a not included? I'm just trying to implement universal link in my project:)

kelset commented 5 years ago

@Bardiamist there was a conflict that looked fairly complex to solve. If you want to try and fix it for yourself (which is the procedure we follow in these scenarios) you can fork the main repo, switch to the 0.59 branch and try the cherry pick, and then submit a pr against that branch.

Bardiamist commented 5 years ago

@kelset I tried and no have conflitct on cherry pick. I think I should not create pr for this.

Screenshot

kelset commented 5 years ago

Uhm, weird. Ok let's try again that commit for 0.59.4

kelset commented 5 years ago

Anyway, now that 0.59.3 is out, let's move to a new issue to clean up the history & remove some noise -> https://github.com/react-native-community/react-native-releases/issues/109