0.59.3 Discussion

[kelset]

Conversation on this thread are limited to 0.59.3 release's major issues and cherry-pick requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.59.3 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.59-stable branch yourself, in order to ensure that the process proceeds smoothly.

[kelset]

To cherry pick:

• https://github.com/facebook/react-native/commit/395197dafe52355c8273f02e1952cdd4ba64a117 (need to make sure that the CLI is ok with this)
• https://github.com/facebook/react-native/commit/56679ed359834c2177c8837d744cc7bf2ceb6b0a (apparently it should be without cherry-pick-conflicts, based on this)

[gaodeng]

Is there any chance of this https://github.com/facebook/react-native/pull/24238 entering version 0.59.4

[tamirrab]

Hi Text: on Android only, textAlign: "right" doing "left" instead of right. and "left" doing "right" instead of left. only on 0.59.3 and only on Android

[kelset]

@tamirrab that looks like a regression, can you please open a dedicated issue in the main repo?

[nzankich]

Could we possibly get this in for 0.59.4? https://github.com/facebook/react-native/pull/23402

[sunnylqm]

Please cherry pick this one: https://github.com/facebook/react-native/commit/556aa93ed72d9dc0f18a1c6d7dec3d9c182fee85

[mazenchami]

I hope this is the right place to post this (as other people just get shut down)...

but when i try to run my project in the simulator, no issues (except for some known warning messages). when i try to archive the project, i get the following error: AppDelegate.m:13:9: fatal error: 'React/RCTLog.h' file not found and also other 'React/RCT*.h' errors.

Info

React Native Environment Info: System: OS: macOS 10.14.4 CPU: (8) x64 Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz Memory: 705.62 MB / 16.00 GB Shell: 3.2.57 - /bin/bash Binaries: Node: 10.4.1 - ~/.nvm/versions/node/v10.4.1/bin/node Yarn: 1.7.0 - /usr/local/bin/yarn npm: 6.4.1 - ~/.nvm/versions/node/v10.4.1/bin/npm Watchman: 4.9.0 - /usr/local/bin/watchman SDKs: iOS SDK: Platforms: iOS 12.2, macOS 10.14, tvOS 12.2, watchOS 5.2 Android SDK: API Levels: 23, 24, 25, 26, 27, 28 Build Tools: 23.0.1, 25.0.0, 25.0.2, 25.0.3, 26.0.2, 27.0.3, 28.0.3 System Images: android-25 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom IDEs: Android Studio: 3.3 AI-182.5107.16.33.5314842 Xcode: 10.2/10E125 - /usr/bin/xcodebuild npmPackages: react: 16.8.3 => 16.8.3 react-native: 0.59.3 => 0.59.3 npmGlobalPackages: create-react-native-app: 2.0.2 react-native-create-library: 3.1.2 react-native-git-upgrade: 0.2.7

[thymikee]

Please cherry-pick https://github.com/facebook/react-native/commit/7e23c7c5654818fa076eeb627b709d39130f57f6 it's important for Lean Core extracted modules to cause less friction in testing :)

[mysport12]

Any chance we can get this one cherry picked? facebook/react-native@6f4239b

[mjmasn]

https://github.com/facebook/react-native/commit/59e50237bff9521d2b78d7576abf4e23d844ac1b please!

[itsjgf]

https://github.com/facebook/react-native/commit/629708bedae65a30e39d234da6b04d6fa101a779 (Crash reporting heaven)

Thanks!

[grabbou]

Hey, Monday sounds like a good moment to do another release! I'll cherry-pick these commits and do 0.59.4 later today.

@itsjgf we have discussed internally to keep crash reporting for 0.60 which is going to arrive really soon.

[grabbou]

Unfortunately, I couldn't cherry-pick the following commits:

• facebook/react-native@395197d - requires changes to the CLI - this will ship under 0.60 where it's synced up

The commit proposed by @thymikee was causing conflicts and I had to import 2 other commits to make it pass.

Pushed and going to do testing now.

[grabbou]

0.59.4 is out now.