search

react-native-community / releases

React Native releases
https://github.com/facebook/react-native/
1.5k stars 405 forks source link

0.59.4 Discussion #113

Closed grabbou closed 5 years ago

grabbou commented 5 years ago

Conversation on this thread are limited to 0.59.4 release's major issues and cherry-pick requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.59.4 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.59-stable branch yourself, in order to ensure that the process proceeds smoothly.

maxschmeling commented 5 years ago

Can we get https://github.com/facebook/react-native/commit/6508b88cfdccdb2da6bfde05faac4647436ce4e7 cherry-picked to remove the annoying RCTImagePickerManager warning?

theolavaux commented 5 years ago

facebook/react-native@60c0a60 fixes a bug where TextInput's caret position resets when toggling on/off the secureTextEntry prop.

rdonnelly commented 5 years ago

https://github.com/facebook/react-native/commit/33b55ccccad56e0b97af294749d728b67b03e658 Is a fix to calculate correct window dimensions for iOS (e.g. split view apps). Can this be cherrypicked? Thanks!

kenvunz commented 5 years ago

facebook/react-native@f01c4e2a14c194c7a02bc5afe1900573af02b0c7 please! This will bring Android closer to iOS in terms of specifying font-weight / font-style combination with custom fonts

BerndSchrooten commented 5 years ago

https://github.com/facebook/react-native/commit/c953e0b4319da0976ece877c09b648a55bc57d9f fixes a problem with Android JSStacktraces that causes apps to crash. Can this be added? Thanks!

RuairiOliver commented 5 years ago

https://github.com/facebook/react-native/commit/f149426c832a37276bde37e1632c22ba65c5f078 fixes several UIImplementation related crashes on Android

ferrannp commented 5 years ago

There has been some regression where you are not able to have a full view (centered) as an empty view for a FlatList. This fixed it https://github.com/facebook/react-native/pull/24339. Can we cherry pick it @grabbou ? :)

mikehardy commented 5 years ago

@RuairiOliver already pulled as of 0.59.2 https://github.com/facebook/react-native/releases/tag/v0.59.2

Worth noting that I was all excited about that one myself but I found that for instance react-native-fs does not use the built-in react-native networking primitives so my library (which uses react-native-fs) was unable to take advantage of this and I still use the Google-Play-dependent Provider patch as a workaround :man_shrugging:

https://github.com/mikehardy/react-native-update-apk/issues/13

RuairiOliver commented 5 years ago

@RuairiOliver already pulled as of 0.59.2 https://github.com/facebook/react-native/releases/tag/v0.59.2

Worth noting that I was all excited about that one myself but I found that for instance react-native-fs does not use the built-in react-native networking primitives so my library (which uses react-native-fs) was unable to take advantage of this and I still use the Google-Play-dependent Provider patch as a workaround 🤷‍♂️

mikehardy/react-native-update-apk#13

Great stuff, thanks for that. Will check it out, I'm on 0.59.1 just now so hopefully it sorts my issue.

grabbou commented 5 years ago

Going to cut 0.59.5 tomorrow. Thanks for your participation.

grabbou commented 5 years ago

@kekenvunz, I didn't cherry-pick this commit. I need to test it with the CLI and link and see how it works. This is most likely going to land in 0.60.

@mikehardy, this commit is not part of 0.59.2 (at least that's what Git tells me). I am re-doing it myself (adding synchronised methods), because it can't be cherry-picked - it depends on a Yoga-related commit that I am not really sure whether I can import.

grabbou commented 5 years ago

Waiting for the tests now. Will keep you posted.

ahce commented 5 years ago

@grabbou can you pick react sync?

RuairiOliver commented 5 years ago

@kekenvunz, I didn't cherry-pick this commit. I need to test it with the CLI and link and see how it works. This is most likely going to land in 0.60.

@mikehardy, this commit is not part of 0.59.2 (at least that's what Git tells me). I am re-doing it myself (adding synchronised methods), because it can't be cherry-picked - it depends on a Yoga-related commit that I am not really sure whether I can import.

I might have confused things there. I had commented about a second commit to cherry pick but deleted that comment after Mike mentioned it was in 0.59.2. Looking forward to trying out 0.59.5, thanks!

mikehardy commented 5 years ago

I might have confused things there. I had commented about a second commit to cherry pick but deleted that comment after Mike mentioned it was in 0.59.2. Looking forward to trying out 0.59.5, thanks!

Correct - and no worries, my comment about 0.59.2 was about the new ability to include Conscrypt and react-native would use it if avaiable, for networking.

I'm most excited about the JSStackTrace / NoSuchKey exception fix :-). Thanks @grabbou !

grabbou commented 5 years ago

@mikehardy & @RuairiOliver - no worries, appreciate the explanation :)

@ahce, React sync commits are usually hard to cherry-pick. I've followed up with Facebook team to check whether it's safe to do.

grabbou commented 5 years ago

Waiting for FB team to answer. Meanwhile, decided to do 0.59.5 w/o React sync. We will release 0.59.6 once we know it's safe and okay to do the bump.

RuairiOliver commented 5 years ago

Up and running on 0.59.5, thanks @grabbou !