0.60.x Discussion - Githubissues

grabbou commented 5 years ago

0.60.0-rc.0 is most likely going to be released tomorrow. The branch is already cut. We are working on the changelog.

Stay tuned.

radeno commented 5 years ago

@grabbou I think better timing for cut first RC should be next week. Easter holidays are behind door and many developers will not work. Even first RC-0 will be as fresh as possible next week.

rhdeck commented 5 years ago

Was the delay monday decided? Or is the drop happening today (Friday)? Looking to test the hot new autolinking.

turnrye commented 5 years ago

@rhdeck yes, we're delaying the publish til Monday. We'll have a WIP changelog today, though it'll still need a lot of refinement.

grabbou commented 5 years ago

Yes. The release is ready to go and tests are passing. I wanted to wait for the changelog because the amount of changes is quite big and we want to wrap it up on the CLI side too.

Vyazovoy commented 5 years ago

Any chances it will be published this week?

piashcse commented 5 years ago

is there any possibility to release 0.60-rc.0 by next week?

grabbou commented 5 years ago

Yes, the plan is to release it this week, ideally before Wednesday. We are still waiting for one CLI issue to be fixed, others have been already resolved.

On Fri, 26 Apr 2019 at 03:53, Mehedi Hassan Piash notifications@github.com wrote:

is there any possibility to release 0.60-rc0 by next week?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/react-native-community/releases/issues/116#issuecomment-486897152, or mute the thread https://github.com/notifications/unsubscribe-auth/AASZZRT66RHVFOAAU2XPDE3PSJOBFANCNFSM4HGX2LDA .

grabbou commented 5 years ago

0.60 is currently blocked due to CocoaPods integration. We have recently migrated default template to CocoaPods but want to avoid users running pod install after react-native init.

Our work can be tracked here: https://github.com/facebook/react-native/pull/24638, tho we are hitting blocker after blocker.

Heading off to holidays, will be back on Monday and that's most likely when I resume my work on the CLI where additional support has to be added.

jeveloper commented 5 years ago

Hope you have a great holiday man , good for you @grabbou

Salakar commented 5 years ago

Any chance we could cherry pick these two small commits:

mikehardy commented 5 years ago

@Salakar - I don't think 0.60 is cut yet, so that comment might best be on 0.59.x for cherry pick?

sunnylqm commented 5 years ago

@mikehardy Already cut and was planned to publish last week https://github.com/facebook/react-native/commits/0.60-stable

grabbou commented 5 years ago

Yes. I can include them too once we are done with the CocoaPods issue.

Update: Unfortunately, the approach in facebook/react-native#24638 ended up being a dead end. We will be running pod install on the client side (meaning you need to have CocoaPods pre-installed).

We are going to implement this ticket https://github.com/react-native-community/cli/issues/368 and we will ship 0.60 as soon as it's resolved.

Unfortunately, given the amount of things to coordinate for 0.60, I can't give you any promises. I will try to do my best to ship it as soon as possible tho.

jsamr commented 5 years ago

Please cherry-pick facebook/react-native@c5c79e5 which prevent a memory leak on iOS!

EDIT Apparently, there is a header issue after having been merged. It's being fixed

jsamr commented 5 years ago

And it would be marvelous if we had font family support in Android, which has just been merged into master facebook/react-native@fd6386a. This PR makes Android xml font declarations operable within the React Native framework.

Basically, it means that you can have mixed nested font styles for custom fonts (fontFamily, fontStyle and fontWeight) without the need to use postscript font name such as OpenSans-Bold). An example is provided in the commit if you want to know how to achieve that.

danilobuerger commented 5 years ago

Is 0.60 going to be recut? If not, please cherry pick

[Android] [Fixed] - LayoutAnimations cause invalid view operations facebook/react-native@20b4879 and its dependent commits.

(This was already requested for 0.59.5, but couldn't be cherry picked because of a dependent commit)

This fixes quite a few crashes when using LayoutAnimations, so its definitely worth picking in my opinion.

radeno commented 5 years ago

I agree with @danilobuerger about recutting new RC0. 22 days from first recut is long time. Many fine bugfixes and some new improvements are very promising to have in first release candidate. But i don't know how much time it takes and how much new problems and issues will appear after merging commits.

jinshin1013 commented 5 years ago

Can we also cherry pick this if it's not too late?:

[iOS] Fixes tintColor not changing on Gif image on iOS facebook/react-native@75380aa

grabbou commented 5 years ago

We will look into re-cutting 0.60 before making the first release. Depending on the tests and stability, we may or may not do it.

I will update you in this issue. Meanwhile, please wait a bit with suggesting cherry-picks until you give the first release a go.

rhdeck commented 5 years ago

Is there a new timeframe? We're four weeks past "most likely going to be released tomorrow." We all know things take time, but would help my dev efforts to have a rough undertstanding of when this would be pre-release, but on npm.

grabbou commented 5 years ago

Unfortunately, no time frame. We are working on it all the time. I will give you an update in two days, where we should have a better overview.

On Tue, 14 May 2019 at 13:08, Ray Deck notifications@github.com wrote:

Is there a new timeframe? We're four weeks past "most likely going to be released tomorrow." We all know things take time, but would help my dev efforts to have a rough undertstanding of when this would be pre-release, but on npm.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/react-native-community/releases/issues/116?email_source=notifications&email_token=AASZZRSJ6NSYAKWSBUNA46TPVKMUNA5CNFSM4HGX2LDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVLEIAY#issuecomment-492192771, or mute the thread https://github.com/notifications/unsubscribe-auth/AASZZRXQHPVAQ52A253VTGTPVKMUNANCNFSM4HGX2LDA .

kelset commented 5 years ago

Is there a new timeframe? We're four weeks past "most likely going to be released tomorrow."

As Mike said, we are doing what we can to get to the point where we can produce a stable 0.60 first RC.

Also, as we communicated here some time ago -> https://github.com/react-native-community/discussions-and-proposals/issues/17#issuecomment-475397553 we are changing a bit the approach to releases so that they are "more distant" from each other, and more "meaty", in a way. This ofc can lead to complexities on the road, which are hard to detect ahead of time.

Nehal-29 commented 5 years ago

facebook/react-native@c5c79e5 @jsamr are we getting a fix related to memory leak in 0.60 version. Really need it.

rhdeck commented 5 years ago

Hi, poking my hand up only because @grabbou mentioned maybe knowing more a week ago, and if so, would be great to understand. Have native components I would love to build centered on the new systems in 0.60.

If no news, so be it.

And if there is any context that would let me or others on thread help, all the better!

grabbou commented 5 years ago

@rhdeck the release is literally now on CircleCI. I'll post an update in 5 minutes or something.

Update: Having some issues with CircleCI checkout: https://circleci.com/gh/facebook/react-native/92623

fjtrujy commented 5 years ago

Hello guys, I'm right now having several issues trying to have the RN 0.6.0.x project with frameworks in the pod file.

So far I see some imports that are wrong.

Do you know if 0.60 is going to support the use of frameworks & Cocoapod ?

This is my current podfile

platform :ios, '9.0'
inhibit_all_warnings!
use_frameworks!

target 'RNUpgrade' do
  # Pods for HelloWorld
  pod 'React', :path => '../node_modules/react-native/'
  pod 'React-Core', :path => '../node_modules/react-native/React'
  pod 'React-DevSupport', :path => '../node_modules/react-native/React'
  pod 'React-fishhook', :path => '../node_modules/react-native/Libraries/fishhook'
  pod 'React-RCTActionSheet', :path => '../node_modules/react-native/Libraries/ActionSheetIOS'
  pod 'React-RCTAnimation', :path => '../node_modules/react-native/Libraries/NativeAnimation'
  pod 'React-RCTBlob', :path => '../node_modules/react-native/Libraries/Blob'
  pod 'React-RCTImage', :path => '../node_modules/react-native/Libraries/Image'
  pod 'React-RCTLinking', :path => '../node_modules/react-native/Libraries/LinkingIOS'
  pod 'React-RCTNetwork', :path => '../node_modules/react-native/Libraries/Network'
  pod 'React-RCTSettings', :path => '../node_modules/react-native/Libraries/Settings'
  pod 'React-RCTText', :path => '../node_modules/react-native/Libraries/Text'
  pod 'React-RCTVibration', :path => '../node_modules/react-native/Libraries/Vibration'
  pod 'React-RCTWebSocket', :path => '../node_modules/react-native/Libraries/WebSocket'

  pod 'React-cxxreact', :path => '../node_modules/react-native/ReactCommon/cxxreact'
  pod 'React-jsi', :path => '../node_modules/react-native/ReactCommon/jsi'
  pod 'React-jsiexecutor', :path => '../node_modules/react-native/ReactCommon/jsiexecutor'
  pod 'React-jsinspector', :path => '../node_modules/react-native/ReactCommon/jsinspector'
  pod 'yoga', :path => '../node_modules/react-native/ReactCommon/yoga'

  pod 'DoubleConversion', :podspec => '../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec'
  pod 'glog', :podspec => '../node_modules/react-native/third-party-podspecs/glog.podspec'
  pod 'Folly', :podspec => '../node_modules/react-native/third-party-podspecs/Folly.podspec'

  target 'RNUpgradeTests' do
      inherit! :search_paths
      # Pods for testing
  end

end

PS: If I just delete the line use_frameworks! it works, but I really prefer the use of frameworks.

Thanks.

erennyuksell commented 5 years ago

Hi, 0.60.0-rc.0 version when will come to npm? Can't wait to use 😃

kelset commented 5 years ago

hey everyone - sorry, we are still having issues with the release pipeline.

We are facing an issue with Detox (which may be fixed, we are testing cherry picking some commits) and one with Buck, where we are waiting from some feedback from the FB side on how to fix.

We should be close, sorry but there are issues that keep popping out lately 😓

kelset commented 5 years ago

Allright, 0.60 RC0 is finally out (thanks Mike & Hector for making this happen!)!

https://github.com/facebook/react-native/releases/tag/v0.60.0-rc.0

Please test it and let us know if you find any major issues! Best way to report them would be to open an issue in the main repo, add in front of the title [0.60 RC] and then link it here 🤗

Kennytian commented 5 years ago

@kelset

✨  Done in 9.76s.
info Installing required CocoaPods dependencies

run react-native init RN060 --version react-native@next， initial project block on CocoaPods installing here.

It's my network issue, never mind it.

peterlazar1993 commented 5 years ago

If you haven't setup CocoaPods before, the initial setup can take some time.

eshikerya commented 5 years ago

have no way to upgrade:

$ react-native upgrade 0.60.0-rc.0
info Fetching diff between v0.59.8 and v0.60.0-rc.0...
error Failed to fetch diff for react-native@0.60.0-rc.0. Maybe it's not released yet?

react-native-git-upgrade fails with message:

$ react-native-git-upgrade 0.60.0-rc.0
git-upgrade info Check for updates 
git-upgrade info Using yarn 1.16.0 
....
git-upgrade info Generate old version template 
git-upgrade ERR! An error occurred during upgrade: 
git-upgrade ERR! Error: Cannot find module '/Users/***/node_modules/react-native/local-cli/generator/copyProjectTemplateAndReplace'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:587:15)
    at Function.resolve (internal/modules/cjs/helpers.js:32:19)
    at runCopyAndReplace (/Users/***/.config/yarn/global/node_modules/react-native-git-upgrade/cliEntry.js:163:32)
    at generateTemplates (/Users/***/.config/yarn/global/node_modules/react-native-git-upgrade/cliEntry.js:151:12)
    at Object.<anonymous> (/Users/***/.config/yarn/global/node_modules/react-native-git-upgrade/cliEntry.js:288:11)
    at Generator.next (<anonymous>)
    at step (/Users/***/.config/yarn/global/node_modules/react-native-git-upgrade/cliEntry.js:171:191)
    at /Users/***/.config/yarn/global/node_modules/react-native-git-upgrade/cliEntry.js:171:361
    at tryCallOne (/Users/***/.config/yarn/global/node_modules/promise/lib/core.js:37:12)
    at /Users/***/.config/yarn/global/node_modules/promise/lib/core.js:123:15

any way to fix it?

mikehardy commented 5 years ago

I like the new example app page a lot. But...I thought it was for react-native 🤔 😆

mikehardy commented 5 years ago

So, I maintain react-native-device-info, and I am really excited to see how it goes with RN060

but if I do

react-native init RN060 --version react-native@next
cd RN060/
npm i react-native-device-info
npx react-native run-android

it hangs in gradle on "Evaluating settings" Ok, so maybe I forgot to link (but auto-linking?), so after doing react-native link react-native-device-info it still hangs in gradle on evaluating settings

I was fully expecting it to fail on AndroidX transition, but Evaluating settings was unexpected.

So maybe it just was the package, I tried it fresh:

react-native init RN060 --version react-native@next
npx react-native run-android
npx react-native start

Now, I definitely forgot to start the packager before the app started, so it gave me the error screen "packager not running etc" when it couldn't download the bundle. Totally okay. But then after I started metro and hit reload...

I get a blank white screen in android emulator API28, when I go to investigate with npx react-native log-android I get:

(virtualenv) mike@kunashir:~/work/react-random/RN060 % npx react-native log-android
info Starting logkitty
error Cannot read property 'VERBOSE' of undefined. Run CLI with --verbose flag for more details.

Which is all unexpected...

If I kill the app and run it again, the example app shows up (but on a Pixel 2 emulator at least it shows "Welcome to React" (vs React-Native) similar to my screenshot above from iPhone X simulator)

Anyone have successful android builds with this and any modules installed?

Anyone else see what I saw on android if you don't have the packager running at first then reload?

kelset commented 5 years ago

hey everyone, as I mentioned earlier can you please create dedicated issues in the main repo and link them here instead of writing the thing directly - it's makes it harder for me to keep the issue in topic 😅

re:

@eshikerya at the moment you shouldn't try to do the upgrade, only to test it via apps - AFAIK we won't produce a diff for the RC. Also, react-native-git-upgrade is no-op now, so you should not be using it. Sorry if it wasn't communicated properly.

@mikehardy

yes, but React & React Native should be the part of the same community, don't they? ;)
there is a PR pending for the CLI, you may need to test after it gets merged: https://github.com/facebook/react-native/pull/25094

mikehardy commented 5 years ago

I will log dedicated issues if these are confirmed problems, but thought for the immediately excited testers I might hear whether it's just something stupid I did or not ;-). I was curious if anyone else had android success before I invested the time with issues and PRs etc etc

eshikerya commented 5 years ago

@kelset tried react-native-git-upgradeas fallback to test the ways I could upgrade. thank you for clarification. any estimate when we would be able to upgrade? AFAIK 0.60 contain a fix our project require, split-view fixes for iOS and Android(app reload when view changed the size)

MoKhajavi75 commented 5 years ago

Crashes on Android....

https://github.com/facebook/react-native/issues/25096

sunnylqm commented 5 years ago

Fix for memory leak in fetch for android https://github.com/facebook/react-native/commit/bccc92dfdd2d85933f2a9cb5c8d1773affb7acba https://github.com/facebook/react-native/commit/a4f7e17a4f06ee713fecbfa1fbb1e632a9d3bf89

fungilation commented 5 years ago

An important one with fetch. Noob question: Will these merged PRs land on next 0.60 rcs and stable?

kelset commented 5 years ago

they landed on master, we will cherry pick for next RC most likely

DoisLucas commented 5 years ago

Good work guys, I'm very excited to test this new release.

xzilja commented 5 years ago

Perhaps a bit of a naive question, but for those of us who were using cocoapods before, besides changing how we include react pods / adding jsi ones, is it safe to continue using third party deps without autolinking? i.e. if I have manually included paths to their podspecs? And perhaps disable autolinking feature somehow i.e. an option in cli config file?

immortalx commented 5 years ago

Does autolinking needs any flag or its already enabled? To install react-native-gesture-handler for example i needed to run react-native link, it added a line to my podfile and i needed to run pod install inside the ios directory.

Is this how it's supposed to be?

matt-oakes commented 5 years ago

@IljaDaderko @immortalx It's an opt-in feature on both platforms. For iOS you need to add these two lines to your ios/Podfile: https://github.com/facebook/react-native/commit/261197d85705dad1a362cc4637aa308c0382dcbe#diff-a3c6c8e64fbbd1efef345c45e3811571

Note that these are currently not in the template Podfile due to an issue with the E2E CI tests.

dishantwalia commented 5 years ago

Crash on some android devices with 64 bit support JSC #https://github.com/facebook/react-native/issues/24261

kelset commented 5 years ago

@MohamadKh75 @dishantwalia that crash wasn't caused by 0.60 RC, so for the purpose of this issue it's not really related. Also, it seems to be connected to the JSC.

kelset commented 5 years ago

about autolinking:

@IljaDaderko

, is it safe to continue using third party deps without autolinking? i.e. if I have manually included paths to their podspecs?

yes, AFAIK - thee autolinking is simply meant to having you not doing those steps.

mjmasn commented 5 years ago

Minor fix for the cherry-pick list https://github.com/facebook/react-native/commit/b45d3b8697c6ed2ce5c6e4eac7bfd14553c79ed8

kelset commented 5 years ago

@eshikerya we published the diff for 0.60RC, so if you want to try again the upgrade command from the CLI it should work this time - but again, it's only an RC so be careful to upgrade only test projects/on safe branches so that you can always reverse without troubles.

react-native-community / releases

0.60.x Discussion #116