0.59.5 Discussion - Githubissues

grabbou commented 5 years ago

Conversation on this thread are limited to 0.59.5 release's major issues and cherry-pick requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.59.5 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.59-stable branch yourself, in order to ensure that the process proceeds smoothly.

chaitanyadeorukhkar commented 5 years ago

facebook/react-native@f01c4e2

It seems like Android could use some support for fontStyle and fontWeight with custom fonts. This is already supported on iOS and would give some love for Android too!

grabbou commented 5 years ago

It's been already requested, please look at my answer here: https://github.com/react-native-community/releases/issues/113#issuecomment-484228780

grabbou commented 5 years ago

I am going to cherry-pick React sync commit and do another release, as agreed yesterday. I now got confirmation from the Facebook team that there shouldn't be any problems. I will consider it "working" when all tests pass.

grabbou commented 5 years ago

React sync commit caused regressions that we didn't spot during testing. Note to self: Never cherry-pick React syncs, especially the ones that just landed, as they can cause some issues in production.

0.60.0-rc.0 will be out shortly and that should give you a place to test it.

grabbou commented 5 years ago

CC: @pvinis - mind updating releases repo to not have that one in upgrade?

pvinis commented 5 years ago

remove .5?

pvinis commented 5 years ago

removing .6 now

matthargett commented 5 years ago

matthargett commented 5 years ago

If there's no compatibility problems, this one would also be great to reduce bundle size. We already do this with a patch on top of RN. https://github.com/facebook/react-native/commit/06cf7face24d0f06e7b690dfc30912ec1e3e1bfb

jtreanor commented 5 years ago

https://github.com/facebook/react-native/commit/31850df116fdd1595dddcd7b37a21568e679ffa7

This is a simple change that fixes several build warnings that have started to appear in Xcode 10.2, particularly when using CocoaPods. It would be great if it could be included in the upcoming version.

danilobuerger commented 5 years ago

Please cherry pick

[Android] [Fixed] - LayoutAnimations cause invalid view operations https://github.com/facebook/react-native/commit/20b4879dfd34716997e92bb5d89b0e4f873fef98

dulmandakh commented 5 years ago

Please cherry pick:

Fixes Android RTL - https://github.com/facebook/react-native/commit/8d3e16831a93079fc5a855a7b0f8b4be508c6942

thorbenprimke commented 5 years ago

Please cherry pick - thanks!

[Android] [Fixed] - The ReactCookieJarContainer/ForwardingCookieHandler now handles the missing WebView gracefully. #24533

matthargett commented 5 years ago

https://github.com/facebook/react-native/commit/c87de765f6a9ebf656c188fa2115a1ba01b7939c

Bardiamist commented 5 years ago

It should fix letterSpacing of TextInput on iOS. https://github.com/facebook/react-native/commit/65c014d19f933771a69c7cbccdbb744330cf13a3 Related issue: https://github.com/facebook/react-native/issues/24263 Pull request: https://github.com/facebook/react-native/pull/23738

estevaolucas commented 5 years ago

Fix accessibility event properties for TextInput https://github.com/facebook/react-native/commit/61c5e356cac844948383800dc64ed23c88181cee
Add convert compatible of NSString for bridge message data https://github.com/facebook/react-native/commit/ffa3b0d4d601fe6788319a7cfd4185b8e4bf462f

NLthijs48 commented 5 years ago

It would be nice if this one could get cherry picked:

https://github.com/facebook/react-native/commit/6f6696fa63dc5f7029cb121c7e0ee98f8d271602 [Android] [Fixed] - JS errors during bundle load were reported as UnknownCppException.

(pull request https://github.com/facebook/react-native/pull/24648)

grabbou commented 5 years ago

Cherry-picked everything except for @matthargett commits (yet to go through them and do it) and @Bardiamist (unfortunately, it doesn't merge clearly).

I'll resume tomorrow morning.

Note: The reason it took so long to get to cherry-picking commits to 0.59 was that we were working hard on 0.60. Now that we are partially on hold there, we are back here!

grabbou commented 5 years ago

There were some discussions happening yesterday regarding what we should still cherry pick before releasing this version.

I am waiting to confirm the results of this conversation (timezone differences) and will be back to the release work.

viktorlarsson commented 5 years ago

Anyone experienced issues with the remote debugging console on iOS? The app becomes unresponsive as soon as it is running on a real device.

kelset commented 5 years ago

@viktorlarsson please open an issue on the main repo for that

kelset commented 5 years ago

hey everyone, expect a new patch release of RN 0.59 next week-ish. We are still discussing this side of the whole process but we'll keep you updated as we decisions are reached.

mikehardy commented 5 years ago

I don't think 0.60.x was cut yet, so I think the comment here asking for cherry-picks to 0.60 should be here? https://github.com/react-native-community/releases/issues/116#issuecomment-489066854

ahce commented 5 years ago

@grabbou is safe React Sync for cherry-pick?

grabbou commented 5 years ago

@matthargett, I didn't cherry-pick the following:

facebook/react-native@5e36b0c (feature request)
https://github.com/facebook/react-native/commit/d5ae59ab2a09cda5109303abb9c269318a1e6686 (while a fix, it can change a behaviour of Promise.finally)
facebook/react-native@06cf7fa (similar to the previous one)
https://github.com/facebook/react-native/commit/1946aee3d9696384d38890269ea705cafd472827 (feature request), https://github.com/facebook/react-native/commit/e980d83389caa3e017ddc8a6cd9603cd680ccc26 (prop change - breaking patch release)
two test-related commits

I am happy to discuss this for next patch release if you really need them.

@ahce - React sync cannot be cherry-picked.

matthargett commented 5 years ago

https://github.com/facebook/react-native/commit/28e0de070d2dae9a486ab5915b6fd76723bd84ef

Fixed haste for all out of tree platforms

grabbou commented 5 years ago

@matthargett - that one has been cherry-picked. I am now waiting for changelog and this is good to go.

danilobuerger commented 5 years ago

@grabbou Is there a reason why the above mentioned bugfix

[Android] [Fixed] - LayoutAnimations cause invalid view operations facebook/react-native@20b4879

was not cherry picked?

grabbou commented 5 years ago

The commit didn't cherry-pick w/o issues - it has conflicts. Let me move it to 0.59.7 discussion issue and we will do another release.

kelset commented 5 years ago

Closing in favour of #124

grabbou commented 5 years ago

The release hasn't been cut yet due to Detox failure - we are investigating it.

react-native-community / releases

0.59.5 Discussion #118