kelset
commented
5 years ago hey Ryan, I was looking through the changelog and I couldn't find a reference to this commit https://github.com/facebook/react-native/commit/a2285b17907cfd3d7cfd311e18027da800a48b2e
Which is the one bringing "feature parity" to the inline views, that were possible in iOS from a long time (via https://github.com/facebook/react-native/commit/486dbe4e8f4e3710c258e22af00b2aa7155ef2f3).
While looking into this, I also found this other commit https://github.com/facebook/react-native/commit/a2a03bc68ba062a96a6971d3791d291f49794dfd which gives a few important insights:
Note that some examples are only supported on iOS because they rely on the inline view being able to size to content. Android's implementation requires that a width and height be specified on the inline view.
(but this is something that probably should live in the docs)
And also a whole list of limitations. So probably worth writing something like "brings feature parity but be aware that it has some limitations", and maybe the link to the commit?
(more details on the whole thing here https://github.com/facebook/react-native/issues/25197#issuecomment-502720957)
This PR adds some improvements to the changelog generator, plus the 0.60 changelog that was dogfooded using the tool.
One important note about this: something about the 0.59 -> 0.60 branch comparison on Github has broken their API (unrelated to my changes). It is not returning all of the results. This MR has been WIP for a long, long time, and I've nudged many community members to check this for any important missing changes. I anticipate however that not everyone got that message, and therefore we will have various corrections to the changelog after this ships. I'm ready to make those fixes, and moving into the future release I plan to more directly tackle the API issue that we encountered.