search

react-native-community / releases

React Native releases
https://github.com/facebook/react-native/
1.5k stars 405 forks source link

0.59.8 Discussion #124

Closed grabbou closed 5 years ago

grabbou commented 5 years ago

Conversation on this thread are limited to 0.59.8 release's major issues and cherry-pick requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.59.7 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.59-stable branch yourself, in order to ensure that the process proceeds smoothly.

grabbou commented 5 years ago

We need to cherry-pick this commit: https://github.com/react-native-community/releases/issues/118#issuecomment-490185543

grabbou commented 5 years ago

Published as 0.59.8. Didn't cherry-pick https://github.com/react-native-community/releases/issues/124#issuecomment-490476233 because it depends on another commit and it can't be applied easily.

I also didn't cherry-pick the "Fix accessibility event properties for TextInput" (0a3bbc by @elucaswork)) because it breaks Detox tests. Waiting for someone to help me debug this.

roshangm1 commented 5 years ago

Was 0.59.7 removed ? I was quick enough to update to 0.57.7 yesterday. :D

karanjthakkar commented 5 years ago

Can we include this commit: https://github.com/facebook/react-native/commit/c953e0b4319da0976ece877c09b648a55bc57d9f? It fixes a crash while parsing stacktraces in Android.

mikehardy commented 5 years ago

@karanjthakkar - I double-checked this one since it has bitten me and I thought it was already included, it appears to already be included? https://github.com/facebook/react-native/blob/v0.59.8/ReactAndroid/src/main/java/com/facebook/react/util/JSStackTrace.java#L29

It was included in 0.59.5 actually - https://github.com/facebook/react-native/blob/v0.59.5/ReactAndroid/src/main/java/com/facebook/react/util/JSStackTrace.java#L29

karanjthakkar commented 5 years ago

@mikehardy I was following this guide to see if that commit made it to a release: https://github.com/react-native-community/releases#when-will-my-fix-make-it-into-a-release And it didnt show up so I thought maybe it isnt released yet.

mikehardy commented 5 years ago

@karanjthakkar very interesting - yes, there is the .59-stable tag on there - https://github.com/facebook/react-native/commit/d7bd6cce38d42dbced48fc8abed96472126e5d69, but the other tags (for the point releases) are not there. Not sure if that is a documentation bug vs updated tooling for releases, or whether the releases aren't tagging, or what? I only double-checked because that cherry-pick in particular was the majority of my Android crashes :-). I really wanted to be sure for myself. Cheers

kelset commented 5 years ago

usually that's caused by cherry-picking, because that basically duplicates the commit so the reference is basically lost, hence why you couldn't see find it. (anyway, gonna hide the comments)

kelset commented 5 years ago

If we can, we should try to cherry pick this: https://github.com/facebook/react-native/commit/30348f789946dc99f5ccd02c85c8decbdb9ac29b

it seems that Gradle 3.4.0 causes crashes in the current RN version.

kelset commented 5 years ago

Also, this should help (if it wasn't cherry picked already) https://github.com/facebook/react-native/commit/8f186b84aeeb2613bf6ae08f20a8547d40179007

jinshin1013 commented 5 years ago

Can we also cherry pick this if it's not too late?:

cihati commented 5 years ago

@grabbou any news on when this will be released?

paolospag commented 5 years ago

@grabbou @kelset any updates about this issue?

kelset commented 5 years ago

👋 given that at the moment there are only, like, 4 commits requested I wanted to wait a bit more before doing a new release. But I feel that I may have some time to tackle this later this week or next week.

kelset commented 5 years ago

Other commit to cherry pick: https://github.com/facebook/react-native/commit/c87de765f6a9ebf656c188fa2115a1ba01b7939c

and https://github.com/facebook/react-native/pull/25098 if and when it lands

kelset commented 5 years ago

Last commit (likely): https://github.com/facebook/react-native/commit/d8fa1206c3fecd494b0f6abb63c66488e6ced5e0

kelset commented 5 years ago

Also, if it works, this would be great: https://github.com/facebook/react-native/commit/46c7ada535f8d87f325ccbd96c24993dd522165d

kelset commented 5 years ago

Hey everyone, I tried to cherry-pick the commits and this is what I ended up with:

I've done quite some testing and I'm fairly sure that upgrading to this won't require you to do any change in your code (but it will support up to Gradle 5.4.1 & Gradle Tools 3.4.0 & Xcode 11).

I'm waiting now for the last commit I had to cherry pick to go green then I'll do the bump commit.

kelset commented 5 years ago

Ok, 0.59.9 is out - and upgrading is as simple as changing the version number.

I'll now create the changelog & the release & the tweet & the new issue for next 0.59.x.

kelset commented 5 years ago

Closing in favour of #127